mesondata: fix mypy warnings #15349
Open
mesondata: fix mypy warnings #15349
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does apparently work without the conversion to a string, but the fix isn't hard
40 tasks
eli-schwartz
requested changes
Dec 5, 2025
| def write_to_private(self, env: 'Environment') -> Path: | ||
| try: | ||
| resource = importlib.resources.files('mesonbuild') / self.path | ||
| resource = importlib.resources.files('mesonbuild') / self.path.as_posix() |
Member
There was a problem hiding this comment.
This is a silly fix IMO because it makes the following code unreachable. What's the specific reason mypy doesn't like this?
Member
Author
There was a problem hiding this comment.
You can't / a Traversable and a PurePath, it wants either a string or a concrete Path
Member
Author
There was a problem hiding this comment.
I'm actually super confused on this now.
Member
Author
There was a problem hiding this comment.
Here's the (3.13) definition of Traversable.__truediv__:
StrPath: TypeAlias = str | os.PathLike[str]
def __truediv__(self, child: StrPath) -> "Traversable": ...PurePath is an instance of os.PathLike[str].
So I'm super confused on why this is showing up as an issue.
Member
Author
|
I think this is a typeshed issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does apparently work without the conversion to a string, but the fix isn't hard