Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add reloader annotation to cosi driver #3169

Merged
merged 2 commits into from
Feb 14, 2025
Merged

fix: add reloader annotation to cosi driver #3169

merged 2 commits into from
Feb 14, 2025

Conversation

cwyl02
Copy link
Contributor

@cwyl02 cwyl02 commented Feb 14, 2025

What problem does this PR solve?:
currently cosi driver deployment doesnt auto restart after config secret change on UI

Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-105746

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@cwyl02 cwyl02 added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Feb 14, 2025
@cwyl02 cwyl02 requested review from takirala and a team February 14, 2025 19:53
@cwyl02 cwyl02 self-assigned this Feb 14, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. services/cosi-driver-nutanix labels Feb 14, 2025
@mesosphere-ci mesosphere-ci added the update-licenses signals mergebot to update licenses.d2iq.yaml label Feb 14, 2025
@coveralls
Copy link

coveralls commented Feb 14, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13337435916

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 13336377734: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

@cwyl02 cwyl02 force-pushed the ychen/cosi-driver-reloader-annotate branch from 354fe1d to ad03d3d Compare February 14, 2025 20:09
@cwyl02
Copy link
Contributor Author

cwyl02 commented Feb 14, 2025

tested on daily cluster and the annotation shows up correctly.

@takirala takirala added needs-backport Needs to be backported to a release branch auto-backport backport-to-release-2.14 labels Feb 14, 2025
@cwyl02 cwyl02 merged commit 9808f2e into main Feb 14, 2025
22 checks passed
@cwyl02 cwyl02 deleted the ychen/cosi-driver-reloader-annotate branch February 14, 2025 22:18
mesosphere-ci pushed a commit that referenced this pull request Feb 14, 2025
@cwyl02
fix: add reloader annotation to cosi driver (#3169)
552112e 
* fix: add reloader annotation to cosi driver

* chore: change to json6902

(cherry picked from commit 9808f2e)
@mesosphere-ci mesosphere-ci mentioned this pull request Feb 14, 2025
Open
@mesosphere-ci
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ release-2.14

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takirala takirala takirala approved these changes

Assignees

@cwyl02 cwyl02

Labels
auto-backport backport-to-release-2.14 needs-backport Needs to be backported to a release branch ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/cosi-driver-nutanix size/S Denotes a PR that changes 10-29 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cwyl02 @coveralls @mesosphere-ci @takirala