Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Llama 3.2 example on Modal with a fun experiment #706

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

erik-dunteman
Copy link

What does this PR do?

We add a new third party recipe for Modal, a serverless python platform that allows people to easily run experiments on Llama.

This is a continuation of the blog:
Beat GPT-4o at Python by searching with 100 dumb LLaMAs

Testing

Given user has Llama 3.2 license approval on Huggingface, has their HF_TOKEN configured as a Modal secret, and has logged into Modal CLI, the included end-to-end script has been ran successfully:

run_e2e.sh

These steps have been included in the README.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

@facebook-github-bot
Copy link

Hi @erik-dunteman!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@erik-dunteman
Copy link
Author

PR submitted by suggestion of @charlesfrye

Copy link
Contributor

@HamidShojanazeri HamidShojanazeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment on the messaging added inline.

@erik-dunteman
Copy link
Author

Just approved, thanks for keeping PR open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants