Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. fixed "INPUT_FILE" path 2. fix create_word_bounded_chunks before read in the text variables 3) processed_text not definedPatch 1 #760

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

keyuchen21
Copy link

@keyuchen21 keyuchen21 commented Oct 30, 2024

What does this PR do?

  1. fixed "INPUT_FILE" path
  2. fix create_word_bounded_chunks was called before read in the "text" variables
  3. processed_text not defined

Before submitting

  • [yes] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [yes] Did you read the contributor guideline,
    Pull Request section?
  • [ no ] Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • [yes] Did you make sure to update the documentation with your changes?
  • [no] Did you write any new necessary tests? - but I ran the code from scratch to make sure it is all good

Thanks for contributing 🎉!

Copy link
Author

@keyuchen21 keyuchen21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the second comit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants