Merge pull request #1016 from metabrainz/node-18-update

chore: Update Node to v18
metabrainz · Sep 18, 2023 · 448e42f · 448e42f
2 parents 6f1372e + d121308
commit 448e42f
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 66 deletions.
diff --git a/.dockerignore b/.dockerignore
@@ -15,6 +15,5 @@ test/
 .gitignore
 .gitmodules
 .tern-project
-.travis-yml
 LICENSE
 README.md
diff --git a/.editorconfig b/.editorconfig
@@ -11,6 +11,6 @@ insert_final_newline = true
 trim_trailing_whitespace = true
 
 # The YAML spec explicitly forbids tabs; we use YAML for ESLint
-[{package.json,.eslintrc,.travis.yml}]
+[{package.json,.eslintrc}]
 indent_size = 2
 indent_style = space
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -66,7 +66,7 @@ jobs:
         uses: actions/setup-node@v1
         with:
           # We could also test on multiple Node versions if needed: https://github.com/actions/setup-node#matrix-testing
-          node-version: '16'
+          node-version: '18'
           # Enables caching NPM dependencies (uses https://github.com/actions/cache under the hood)
           cache: 'yarn'
 

diff --git a/.travis.yml b/.travis.yml
diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM metabrainz/node:16 as bookbrainz-base
+FROM metabrainz/node:18 as bookbrainz-base
 
 ARG DEPLOY_ENV
 ARG GIT_COMMIT_SHA

diff --git a/package.json b/package.json
@@ -24,7 +24,7 @@
     "dupreport": "npx jsinspect src/ || true"
   },
   "engines": {
-    "node": ">= 16.16.0"
+    "node": ">= 18"
   },
   "browserslist": "> 0.25%, not dead",
   "dependencies": {