feat(Identifier types): Identifier Types Page and Identifier Types Editor #1012
Conversation
I didn't click during the proposal review process, but we probably don't want a delete endpoint. Otherwise, we would have to cascade modify all the identifiers that use that identifier type, probably not a good idea (I'd bet you 5 schmekels that's how we got that ID sequence issue…). |
| function isValid() { | ||
| return Boolean(formData.entityType); |
There was a problem hiding this comment.
The name of this function suggests more validation than just whether an entity type has been selected.
Is a portion of this validation function missing?
There was a problem hiding this comment.
At the outset, I wanted an isValid function to check those required fields on the form which cannot directly be checked by adding a required flag. In case of the relationship type editor, there were two such fields: a sourceEntityType and a targetEntityType. In this case, we only have one such field: entityType.
I agree the name isValid itself is a bit more general(and maybe misleading), perhaps it should have been something like checkRequiredFields. We can also get rid of this function here, but I went ahead with it just to make it similar to the relationship type editor code.
There was a problem hiding this comment.
Ideally it should check all the required fields, but the combination of the required attribute on the inputs and the error thrown by the server is probably sufficient.
Trying to prove that point, I edited the html to remove the required attribute on all the inputs (but selecting an entity type to satisfy isValid) and I can submit with empty values, and get an error back from the server:
IMO this is sufficient for this type of interface, and if proper validation should be done it should be done on the server-side.
There was a problem hiding this comment.
so what I mean by required fields is this: for non-select fields, there is prompt which occurs like this in case we try to submit the form without entering anything in that field:
For the select type fields, there is no such validation. In order to prevent sending incomplete data to backend, we should probably use this function to do this in frontend itself:
There was a problem hiding this comment.
Although you're right, ideally we should be doing for all the fields. The only reason I went for this is because for the non-select fields at least there is a prompt which tells us Please fill out this field., while for the select field, there is no such prompt.
There was a problem hiding this comment.
so what I mean by required fields is this: for non-select fields, there is prompt which occurs like this in case we try to submit the form without entering anything in that field:
Yep, completely understand, tested and approved :)
I just tried to break it by manually modifying the HTML in my page to allow empty inputs, which would not normally happen in any reasonable circumstance I can imagine.
|
@the-good-boy I believe you should have a page for re-indexing the server. |
Yeah definitely it would be better. Perhaps, we should just redirect to some page after a successful reindex? How about we redirect to the homepage, but there is a brief message which indicates that the reindex was successful? Let me think about this. |
|
Yes I think any UI would be better than the current state of it :) IMO a page with a "start reindexing" button and a way to indicate the status (i.e. in progress // finished) would be perfect. To start with, maybe even just a page with a button would be an improvement :) |
This PR deals with Identifier Types.
Now, there is link to access an Identifier Types Page from the 'Docs' Menu:
The new Identifier Types Page has the tree structure similar to the Relationship Types page. It also has tabs for different entity types!
We also have a link to go to an Identifier Type Editor:
Now, privileged users can add and edit identifier types!
