MBS-13781: Support browsing genres by collection in the API #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added the feature in the last schema change but I completely forgot the WS side of it. This implements it, plus some tests. I had to move genre_all to be the last one defined so that Catalyst would choose it first and avoid breaking genre lists, apparently; see https://metacpan.org/dist/Catalyst-Runtime/view/lib/Catalyst/RouteMatching.pod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-13781
Description
We added the feature in the last schema change but I completely forgot the WS side of it. This implements it, plus some tests.
Testing
Manually, and I added
BrowseGenrestests. AFAICT this is the only collection browse JSON test, too.