Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBS-13802: Always use "Created (in)" for characters #3403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MBS-13802: Always use "Created (in)" for characters #3403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions root/artist/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ export function artistBeginAreaLabel(typeId: ?number): string {
case 5:
case 6:
return addColonText(lp('Founded in', 'group artist'));
case 4:
return addColonText(lp('Created in', 'character artist'));
default:
return addColonText(l('Begin area'));
}
Expand Down
14 changes: 14 additions & 0 deletions root/static/scripts/edit/MB/Control/ArtistEdit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ MB.Control.ArtistEdit = function () {
* Unknown: 0
* Person: 1
* Group: 2
* Character: 4
* Orchestra: 5
* Choir: 6
*/
Expand Down Expand Up @@ -70,6 +71,19 @@ MB.Control.ArtistEdit = function () {
self.disableGender();
break;

case '4':
self.changeDateText(
addColonText(lp('Created', 'character artist')),
addColonText(lp('Ended', 'artist end date')),
l('This artist has ended.'),
);
self.changeAreaText(
addColonText(lp('Created in', 'character artist')),
addColonText(l('End area')),
);
self.enableGender();
break;

case '0':
default:
self.changeDateText(
Expand Down