More spam tools #3585
More spam tools #3585
Conversation
mwiencek
force-pushed
the
spammers-b-gone
branch
2 times, most recently
from
0eb3efd to
e795b7f
Compare
|
Ooh, can't wait to try this!! |
|
I'm a bit confused about the second commit, given you changed nothing in the eslint configuration - what was the intention? Should we change our line |
There was a problem hiding this comment.
Tested locally, seems to work well.
I added a link to the new admin page from the admin menu.
I added the banhammer button also to the beginner editors report, although to be honest I think your new tool basically seems to supersede that to the point where we could delete it instead? I barely check it anyway but whenever I do it's for spam hunting.
| $c->model('Editor')->update_privileges($editor, \%privilege_updates); | ||
|
|
||
| if ($privilege_updates{spammer}) { | ||
| $c->forward('/discourse/log_out', [$editor]); |
There was a problem hiding this comment.
Can we actually delete their accounts? That's what I usually do by hand...
We use that for
We can probably remove it if nobody uses it. I considered turning the possible-spammers page into a general "new users" page where you can filter by website/bio by regular expression, and that would definitely replace the report entirely. (In fact, we could merge the email and privilege search forms into this page too.) But I left that possibility open for later... |
|
@Aerozol, do you ever use the beginners report? |
|
No! But I didn't know about it's handy "delete" feature until I looked, right now :0 |
|
It used to be handy when we deleted spammers, but honestly after we changed to mark them as spammers instead, I have pretty much never used it anymore. |
|
Oh indeed - that button should be a "mark as spammer" button, for sure, or I guess there is no use-case for it. |
|
Well, this pull request adds such a button :) But it also adds what feels like an equally good or even better option to browse the beginners too. I guess we should put it on beta and see how we two feel about it, and we can drop the report later if we prefer the other tool. |
The latest stable version doesn't work with Flow component syntax at all.
Fixes MBS-12916 Fixes MBS-13306 This adds a tool I've been using locally, /admin/possible-spammers, which lists beginner accounts having a website or biography, and includes a button to mark them as spam in a single click. An "Unused" column indicates if the account has been used at all, using the same criteria as the script added for MBS-9356, except it allows having a confirmed email address (many spammers do).
mwiencek
force-pushed
the
spammers-b-gone
branch
from
cd2e83e to
ff8d42c
Compare
|
Added a commit to actually fix the new eslint warnings brought to light by b9e47ad |
Fixes MBS-12916
Fixes MBS-13306
This adds a tool I've been using locally, /admin/possible-spammers, which lists beginner accounts having a website or biography, and includes a button to mark them as spam in a single click. An "Unused" column indicates if the account has been used at all, using the same criteria as the script added for MBS-9356, except it allows having a confirmed email address (many spammers do).
Note: I'm open to minor improvement suggestions, but I don't intend to spend too much time on this. I built this tool for myself to use locally (over ssh tunnel) and it works fine for that purpose, but I'm submitting it because other account admins would benefit from it too.