MBS-12729: Drop support for search.musicbrainz.org #3590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes all references to SEARCH_ENGINE (since there's just the one, SOLR, nowadays, so we should assume it). It also drops references to search.musicbrainz.org which is now gone. The INSTALL.md section about rate limiting seems fairly useless now, so I turned it into basic info about search servers.
reosarevok
added
Refactoring
reosarevok
commented
Jul 4, 2025
Comment on lines
+839
to
+841
| # Solr has a bug where the dismax end point behaves differently | ||
| # from edismax (advanced) when the query size is 1. This is a fix | ||
| # for that. See https://issues.apache.org/jira/browse/SOLR-12409 |
There was a problem hiding this comment.
This seems to have been resolved in 2019: https://issues.apache.org/jira/browse/SOLR-12409
We should probably just use select always now? But I'm not familiar enough with this and haven't tested it yet, so I thought I'd ask first :)
There was a problem hiding this comment.
That ticket was only resolved as "Information Provided" (see the comments). In fact it appears that it's not actually a bug. The code linked in the first comment (if that is indeed the source of this behavior) is still present to this day with the same comment indicating that it's intentional:
we need at least two or there shouldn't be a boost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-12729
Descriptions
This removes all references to
SEARCH_ENGINE(since there's just the one,SOLR, nowadays, so we should assume it). It also drops references tosearch.musicbrainz.orgwhich is now gone.The
INSTALL.mdsection about rate limiting seems fairly useless now, so I turned it into basic info about search servers.Questions
Should we have any default/placeholder
SEARCH_SERVERvalue?Testing
None.