MBS-14107: Support new style Brahms/IRCAM work links #3596
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New IRCAM work links are just /work/$work_name and were being blocked by our current code. This detects them and cleans them up as work links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-14107
Description
New IRCAM work links are just
/work/$work_name(e.g. https://brahms.ircam.fr/fr/work/luci) and were being blocked by our current code. This detects them and cleans them up as work links.Testing
Added a test to the list and made sure old links still work since they can still be found as search results and whatnot and there's no trivial way to convert one to the other (they don't even redirect yet).