MBS-14097: Add /-/ slug to Target links #3599
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the current cleanup used to work, the links started failing at times and they seem to just be broken entirely now. Target seems to now require an extra *something* between /p or /b and the entity code - this adds /-/ which is our usual empty placeholder.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-14097
Problem
While the current Target cleanup used to work, the links started failing at times and they seem to just be broken entirely now, leading to errors such as "We're sorry! This page is currently unavailable. Please try again later."
Solution
Target seems to now require an extra something between
/por/band the entity code - this adds/-/which is our usual empty placeholder.Testing
Manually checked
/-/works fine, and modified the tests to ensure it's being added.