MBS-14110: Don't try to log in using outdated username #3600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we rename a user, their remember_login cookie still points to their old, no longer existing username. That means we were trying to log a non-existing user if their session had expired, causing an ISE. This makes sure the user we're trying to log in actually exists. Renamed users with expired sessions will still have to log in again, but at least they won't get an ISE before that; logging in again is not a big issue anyway since that's the first thing I would tell them to do to propagate the change to LB anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-14110
Problem
When we rename a user, their remember_login cookie still points to their old, no longer existing username. That means we were trying to log a non-existing user if their session had expired, causing an ISE.
Solution
This makes sure the user we're trying to log in actually exists. Renamed users with expired sessions will still have to log in again, but at least they won't get an ISE before that; logging in again is not a big issue anyway since that's the first thing I would tell them to do to propagate the change to LB anyway.
Testing
Manually, by logging in with a random use with "remember me" checked in my local server, deleting the user's session cookie by hand, then renaming the user in incognito and reloading the page the user was on.