Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Windows and macOS builds to PyQt 6.7.1 / Qt 6.7.2 #2535

Merged
merged 3 commits into from
Aug 10, 2024

Conversation

phw
Copy link
Member

@phw phw commented Aug 10, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Upgrade the macOS and Windows builds to the latest PyQt 6.7.1 and Qt6 6.7.2 release.

This was attempted in #2420 already, but test where segfaulting. I have a slight suspicion this was also related to the strxfrm related crashes that got fixed in #2533, but I have not verified this. Anyway, builds are passing now.

This will resolve one of the open todos in #2423 .

@phw phw requested a review from zas August 10, 2024 16:13
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit ecad5bd into metabrainz:master Aug 10, 2024
44 checks passed
@phw phw deleted the pyqt-6.7 branch August 10, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants