Filter feature proposed changes

[rdswift]

Summary

• This is a…
  • Bug fix
  • Feature addition
  • Refactoring
  • Minor / simple change (like a typo)
  • Other
• Describe this change in 1-2 sentences: Suggested improvements to the newly added metadata filtering system.

Problem

The newly added metadata filtering system provides some unexpected results.

• JIRA ticket (optional): PICARD-XXX

Solution

This PR proposes some changes as follows:

1. Add Persistent Settings:

   • Add persistent settings for selected filters, so that the settings are retained between sessions.

2. Filter Logic Changes:

   • Return True if no filters selected or no filter text entered.
   • Return True if no tags are found for selected filters.
   • Return True if tag found in selected filters and filter text in tag value.
   • Return False if one or more tags found in selected filters and filter text not in any values of the tags found.

3. Add Master Selection Checkbox:

   • Add checkbox at the top of the dialog to select / clear all filters.

4. Add Logging:

   • Add debug logging when the set of filterable tags is updated.

The new dialog looks like:

Action

Additional actions required:

• Update Picard documentation (please include a reference to this PR)
• Other (please specify below)

[zas]

Very good improvements. LGTM.

[rdswift]

Two questions:

1. Should we also persist the filter text?
2. Should we include an option to filter on ANY metadata tag, including hidden tags and those not found in the filterable_tags set? I can't think of a use case, but there may be one that other users might find necessary.

Both are fairly easy to include, but I don't want to overdo this with things that might not make sense.

[zas]

1. Should we also persist the filter text?

I'd say no.

2. Should we include an option to filter on ANY metadata tag, including hidden tags and those not found in the filterable_tags set? I can't think of a use case, but there may be one that other users might find necessary.

Nope, keep it simple.