Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcpmss clamping in egress policies #161

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

tcpmss clamping in egress policies #161

wants to merge 5 commits into from
+76 −15

Conversation

chbmuc
Copy link

@chbmuc chbmuc commented Jul 11, 2023

implementation for #160

majst01
majst01 reviewed Jul 11, 2023
View reviewed changes
pkg/nftables/nftables.tpl
# rate limits
{{- range .RateLimitRules }}
{{ . }}
{{- end }}

{{ end }}{{ if gt (len .ForwardingRules.TcpMss) 0 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{ end }}{{ if gt (len .ForwardingRules.TcpMss) 0 }}
{{- end }}
{{- if gt (len .ForwardingRules.TcpMss) 0 }}

This should do the trick to ommit the newline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majst01 majst01 majst01 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chbmuc @majst01