Add S3 as backend #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for new options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Co-authored-by: @knht
This PR adds S3 as possible backend for the audit logs.
We tried to expose only the relevant fields of the fluentbit config for S3. If fields are missing we can add them. Docs of the config.
I am not 100% happy with the validation part. I think it would be better to check this directly during the
shootchange and this would be in my opinion to big for that PR, therefore I added it like the validations in splunk.I also think it would make sense to move the backends to dedicated packages to avoid accidental use of const. But I also think that would make this PR more complex. So that should be done in a dedicated PR.