WIP: ⚠️ Remove Metal3Machine owner reference from BMH #2506

kashifest · 2025-04-22T07:06:40Z

Metal3Machine should not own BMH. It should consume it and release it when not needed. we already put a M3M consumer reference on BMH. This also would mean that for pivoting use cases we must add the clusterctl move labels in the CRDs. Otherwise BMH wont be pivoted to target clusters.

⚠️ Now, BMH object/CRD needs to have The object has the clusterctl.cluster.x-k8s.io/move label or the clusterctl.cluster.x-k8s.io/move-hierarchy label to make sure BMH is pivoted to target cluster and removed from the source. clusterctl.cluster.x-k8s.io/move and clusterctl.cluster.x-k8s.io/move-hierarchy labels could be applied to single objects or at the CRD level (the label applies to all the objects).

We still keep the removal of owner reference code for one minor release cycle to facilitate upgrade scenario where a BMH could still have an owner reference set from previous version. Starting from v1.11.x minor cycle we will remove this code also.
Signed-off-by: Kashif Khan [email protected]

metal3-io-bot · 2025-04-22T07:06:46Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tuminoid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kashifest · 2025-04-22T07:07:15Z

/hold
This is still WIP, pushed here only for testing, not ready to be merged yet.

kashifest · 2025-04-22T07:08:01Z

/test metal3-centos-e2e-integration-test-main

kashifest · 2025-04-22T12:18:21Z

/test metal3-centos-e2e-integration-test-main

kashifest · 2025-04-23T06:46:18Z

/test metal3-centos-e2e-integration-test-main

kashifest · 2025-04-23T06:49:33Z

/test metal3-ubuntu-e2e-integration-test-main

kashifest · 2025-04-23T07:19:07Z

/test metal3-centos-e2e-integration-test-main

kashifest · 2025-04-23T07:19:57Z

/hold

kashifest · 2025-04-23T07:20:06Z

/hold cancel

kashifest · 2025-04-23T07:20:18Z

/hold

kashifest · 2025-04-23T08:56:41Z

/test metal3-ubuntu-e2e-integration-test-main

kashifest · 2025-04-23T09:30:59Z

Run1: passed test https://jenkins.nordix.org/view/Metal3/job/metal3-centos-e2e-integration-test-main/1152/console

kashifest · 2025-04-23T09:31:11Z

/test metal3-centos-e2e-integration-test-main

kashifest · 2025-04-23T12:36:41Z

Run 2: Failed but unrelated IPA download issue https://jenkins.nordix.org/view/Metal3/job/metal3-centos-e2e-integration-test-main/1154/consoleFull

kashifest · 2025-04-23T12:37:05Z

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

kashifest · 2025-04-24T07:17:52Z

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

kashifest · 2025-04-24T12:13:38Z

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

kashifest · 2025-04-25T06:19:19Z

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

lentzi90 · 2025-10-21T07:57:59Z

/hold cancel

lentzi90 · 2025-10-21T07:58:07Z

/hold

lentzi90 · 2025-10-21T09:03:49Z

/override build

metal3-io-bot · 2025-10-21T09:03:57Z

@lentzi90: Overrode contexts on behalf of lentzi90: build

Details

In response to this:

/override build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tuminoid · 2025-10-21T11:09:34Z

Converted to draft in attempt to stop Prow.

tuminoid · 2025-10-21T11:17:32Z

@kashifest: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-centos-e2e-integration-test-main 7e055ce link true /test metal3-centos-e2e-integration-test-main
build 7e055ce link true /test build
Full PR test history. Your PR dashboard.

This should be the last one if the draft conversion worked.

tuminoid · 2025-10-21T13:03:06Z

It kept spamming :(

Metal3Machine should not own BMH. It should consume it and release it when not needed. we already put a M3M consumer reference on BMH. This also would mean that for pivoting use cases we must add the clusterctl move labels in the CRDs. Otherwise BMH wont be pivoted to target clusters. ⚠️ Now, BMH object/CRD needs to have The object has the clusterctl.cluster.x-k8s.io/move label or the clusterctl.cluster.x-k8s.io/move-hierarchy label to make sure BMH is pivoted to target cluster and removed from the source. clusterctl.cluster.x-k8s.io/move and clusterctl.cluster.x-k8s.io/move-hierarchy labels could be applied to single objects or at the CRD level (the label applies to all the objects). We still keep the removal of owner reference code for one minor release cycle to facilitate upgrade scenario where a BMH could still have an owner reference set from previous version. Starting from v1.11.x minor cycle we will remove this code also. Signed-off-by: Kashif Khan <[email protected]>

Signed-off-by: Kashif Khan <[email protected]>

kashifest · 2025-10-22T07:04:19Z

/test metal3-centos-e2e-integration-test-main

kashifest · 2025-10-22T07:44:34Z

/test metal3-centos-e2e-integration-test-main

Signed-off-by: Kashif Khan <[email protected]>

kashifest · 2025-10-29T07:26:01Z

/test metal3-centos-e2e-integration-test-main

kashifest · 2025-11-03T08:11:43Z

/test metal3-centos-e2e-integration-test-main

metal3-io-bot · 2025-11-03T09:13:42Z

@kashifest: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
unit	`4fe2f81`	link	true	`/test unit`
metal3-centos-e2e-integration-test-main	`4fe2f81`	link	true	`/test metal3-centos-e2e-integration-test-main`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

metal3-io-bot · 2025-11-03T09:13:42Z

@kashifest: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
unit	`4fe2f81`	link	true	`/test unit`
metal3-centos-e2e-integration-test-main	`4fe2f81`	link	true	`/test metal3-centos-e2e-integration-test-main`

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

metal3-io-bot · 2025-11-03T09:13:50Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2025

metal3-io-bot requested review from Rozzii and adilGhaffarDev April 22, 2025 07:06

metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 22, 2025

metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2025

kashifest changed the title ~~WIP: Remove Metal3Machine owner reference from BMH~~ WIP: ⚠️ Remove Metal3Machine owner reference from BMH Apr 22, 2025

kashifest force-pushed the remove/bmh-ownerRef branch from 4def180 to e92061b Compare April 23, 2025 06:46

metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2025

metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2025

kashifest force-pushed the remove/bmh-ownerRef branch from e92061b to 1a836b0 Compare April 24, 2025 07:17

kashifest force-pushed the remove/bmh-ownerRef branch from 1a836b0 to 74bbadf Compare April 24, 2025 12:12

kashifest force-pushed the remove/bmh-ownerRef branch from 74bbadf to 24a8ff0 Compare April 25, 2025 06:17

metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2025

metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2025

metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2025

tuminoid marked this pull request as draft October 21, 2025 11:09

kashifest and others added 3 commits October 22, 2025 09:53

BMH pause annotation should be synced with CAPM3 machine

101a0ed

Signed-off-by: Kashif Khan <[email protected]>

Block Move

65cee5d

Signed-off-by: Kashif Khan <[email protected]>

kashifest force-pushed the remove/bmh-ownerRef branch from 7e055ce to 16b96fc Compare October 22, 2025 07:03

metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2025

kashifest marked this pull request as ready for review October 22, 2025 07:04

metal3-io-bot requested a review from lentzi90 October 22, 2025 07:04

kashifest force-pushed the remove/bmh-ownerRef branch 2 times, most recently from 633c68c to 346d48a Compare October 22, 2025 07:37

Add manual paused annotation

4fe2f81

Signed-off-by: Kashif Khan <[email protected]>

kashifest force-pushed the remove/bmh-ownerRef branch from 346d48a to 4fe2f81 Compare October 29, 2025 07:25

metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2025

WIP: ⚠️ Remove Metal3Machine owner reference from BMH #2506

Are you sure you want to change the base?

WIP: ⚠️ Remove Metal3Machine owner reference from BMH #2506

Uh oh!

Conversation

kashifest commented Apr 22, 2025

Uh oh!

metal3-io-bot commented Apr 22, 2025

Uh oh!

kashifest commented Apr 22, 2025

Uh oh!

kashifest commented Apr 22, 2025

Uh oh!

kashifest commented Apr 22, 2025

Uh oh!

kashifest commented Apr 23, 2025

Uh oh!

kashifest commented Apr 23, 2025

Uh oh!

kashifest commented Apr 23, 2025

Uh oh!

kashifest commented Apr 23, 2025

Uh oh!

kashifest commented Apr 23, 2025

Uh oh!

kashifest commented Apr 23, 2025

Uh oh!

kashifest commented Apr 23, 2025

Uh oh!

kashifest commented Apr 23, 2025

Uh oh!

kashifest commented Apr 23, 2025

Uh oh!

kashifest commented Apr 23, 2025

Uh oh!

kashifest commented Apr 23, 2025

Uh oh!

kashifest commented Apr 24, 2025

Uh oh!

kashifest commented Apr 24, 2025

Uh oh!

kashifest commented Apr 25, 2025

Uh oh!

lentzi90 commented Oct 21, 2025

Uh oh!

lentzi90 commented Oct 21, 2025

Uh oh!

lentzi90 commented Oct 21, 2025

Uh oh!

metal3-io-bot commented Oct 21, 2025

Uh oh!

tuminoid commented Oct 21, 2025

Uh oh!

tuminoid commented Oct 21, 2025

Uh oh!

tuminoid commented Oct 21, 2025

Uh oh!

kashifest commented Oct 22, 2025

Uh oh!

kashifest commented Oct 22, 2025

Uh oh!

kashifest commented Oct 29, 2025

Uh oh!

kashifest commented Nov 3, 2025

Uh oh!

metal3-io-bot commented Nov 3, 2025

Uh oh!

metal3-io-bot commented Nov 3, 2025

Uh oh!

metal3-io-bot commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants