🌱Decouple CAPM3 from using dev-env in E2E setup #2665

smoshiur1237 · 2025-07-24T09:17:25Z

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

smoshiur1237 · 2025-07-24T09:20:37Z

/hold

smoshiur1237 · 2025-10-20T13:29:58Z

I will open it when start working on this .

smoshiur1237 · 2025-11-04T11:31:03Z

We will start working on it

smoshiur1237 · 2025-11-04T11:32:01Z

/cc @adilGhaffarDev

adilGhaffarDev · 2025-11-04T18:13:51Z

/close
Lets open new one . This is sending too many notifications.

metal3-io-bot · 2025-11-04T18:13:56Z

@adilGhaffarDev: Closed this PR.

Details

In response to this:

/close
Lets open new one . This is sending too many notifications.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

smoshiur1237 · 2025-11-05T09:15:46Z

rebasing it

peppi-lotta

I think this is a bit outdated overall if the idea is to follow what BMO is doing for e2e. I think you should wait until use irso PR merges as it will have quite many changes you are touching here as well. Using IRSO in CAPM3 will allow you to follow the BMO way or doing e2e more closely and I would suggest you start by checking that everything that is copied from BMO is up to date here.

scripts/ci-e2e.sh

peppi-lotta · 2025-12-10T07:51:57Z

scripts/ci-e2e.sh

-cat <<-EOF >"${M3_DEV_ENV_PATH}/config_${USER}.sh"
-export CAPI_VERSION="v1beta2"
-export CAPM3_VERSION=${CAPM3_VERSION:-"v1beta1"}
-export NUM_NODES=${NUM_NODES:-"4"}
-export KUBERNETES_VERSION=${KUBERNETES_VERSION}
-export IMAGE_OS=${IMAGE_OS}
-export FORCE_REPO_UPDATE="false"
-export SKIP_NODE_IMAGE_PREPULL="true"
-export USE_IRSO="${USE_IRSO:-false}"
-EOF


Do these need to be exported somewhere else for example environment.sh?

We are not using dev-evn, thats why the config was deleted. But we can keep them in environment.sh file

peppi-lotta · 2025-12-10T07:54:41Z

scripts/ci-e2e.sh

+  virsh -c qemu:///system net-start "${network}"
+  virsh -c qemu:///system net-autostart "${network}"
+done



Once you rabesa on top of Use IRSO in e2e tests -PR.

These ip rules etc need to be added for irso: https://github.com/metal3-io/baremetal-operator/blob/cb8392cd1f9cd64f5640400b61dea1a726587a87/hack/ci-e2e.sh#L66C1-L99C31

scripts/ci-e2e.sh

peppi-lotta · 2025-12-10T07:59:47Z

scripts/ci-e2e.sh

-  fi
 done

 for overlay in "${IRONIC_OVERLAYS[@]}"; do


This will change to IRSO_OVELAYS once you rebase ontop of Use IRSO in e2e tests -PR. The username and password stuff will change as well.

test/e2e/bmc.go

test/e2e/config/bmcs.yaml

peppi-lotta · 2025-12-10T08:06:17Z

hack/e2e/net.xml

@@ -0,0 +1,16 @@
+<network>
+  <name>baremetal-e2e</name>


This file is probably not needed or should be rename.

metal3-io-bot · 2025-12-15T12:00:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign smoshiur1237 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

smoshiur1237

Thanks @peppi-lotta for your review. I will address them

This commit pushes changes needed so that we no longer need to run dev-env's make in preparation for E2E. Signed-off-by: Huy Mai <[email protected]> Signed-off-by: smoshiur1237 <[email protected]>

metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2025

metal3-io-bot requested review from honza and kashifest July 24, 2025 09:17

metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 24, 2025

smoshiur1237 changed the title ~~WIP🌱Decouple CAPM3 from using dev-env in E2E setup~~ 🌱Decouple CAPM3 from using dev-env in E2E setup Jul 24, 2025

metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2025

metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025

smoshiur1237 force-pushed the decouple-dev-moshiur branch 4 times, most recently from a3154a7 to 264c573 Compare July 31, 2025 06:41

metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2025

smoshiur1237 force-pushed the decouple-dev-moshiur branch from 264c573 to f151607 Compare August 5, 2025 06:39

metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 5, 2025

smoshiur1237 force-pushed the decouple-dev-moshiur branch from f151607 to 5477d81 Compare August 13, 2025 07:13

metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 13, 2025

smoshiur1237 closed this Oct 20, 2025

smoshiur1237 reopened this Nov 4, 2025

metal3-io-bot requested a review from adilGhaffarDev November 4, 2025 11:32

metal3-io-bot closed this Nov 4, 2025

smoshiur1237 reopened this Nov 5, 2025

smoshiur1237 force-pushed the decouple-dev-moshiur branch from 5477d81 to bf80525 Compare November 5, 2025 09:16

metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 5, 2025

smoshiur1237 force-pushed the decouple-dev-moshiur branch from bf80525 to 3f4dcc1 Compare November 26, 2025 07:47

metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2025

smoshiur1237 force-pushed the decouple-dev-moshiur branch 2 times, most recently from 8953fbc to f276218 Compare November 26, 2025 09:48

metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2025

peppi-lotta reviewed Dec 10, 2025

View reviewed changes

smoshiur1237 force-pushed the decouple-dev-moshiur branch from f276218 to 44f4c9e Compare December 15, 2025 11:59

metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2025

smoshiur1237 force-pushed the decouple-dev-moshiur branch 2 times, most recently from fcb1049 to 1033bcd Compare December 15, 2025 12:37

metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 15, 2025

smoshiur1237 commented Dec 15, 2025

View reviewed changes

smoshiur1237 force-pushed the decouple-dev-moshiur branch 2 times, most recently from 36afe84 to 9c98b90 Compare December 15, 2025 13:36

metal3-io-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 15, 2025

smoshiur1237 force-pushed the decouple-dev-moshiur branch 2 times, most recently from c2070a5 to af5bdcd Compare December 16, 2025 08:56

Stop using dev-env in E2E setup

d903ba8

This commit pushes changes needed so that we no longer need to run dev-env's make in preparation for E2E. Signed-off-by: Huy Mai <[email protected]> Signed-off-by: smoshiur1237 <[email protected]>

smoshiur1237 force-pushed the decouple-dev-moshiur branch from af5bdcd to d903ba8 Compare December 16, 2025 10:58

metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 16, 2025

🌱Decouple CAPM3 from using dev-env in E2E setup #2665

Are you sure you want to change the base?

🌱Decouple CAPM3 from using dev-env in E2E setup #2665

Uh oh!

Conversation

smoshiur1237 commented Jul 24, 2025

Uh oh!

smoshiur1237 commented Jul 24, 2025

Uh oh!

smoshiur1237 commented Oct 20, 2025

Uh oh!

smoshiur1237 commented Nov 4, 2025

Uh oh!

smoshiur1237 commented Nov 4, 2025

Uh oh!

adilGhaffarDev commented Nov 4, 2025

Uh oh!

metal3-io-bot commented Nov 4, 2025

Uh oh!

smoshiur1237 commented Nov 5, 2025

Uh oh!

peppi-lotta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

peppi-lotta Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

smoshiur1237 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

peppi-lotta Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

peppi-lotta Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peppi-lotta Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

metal3-io-bot commented Dec 15, 2025

Uh oh!

smoshiur1237 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants