Skip to content

Conversation

@Sunnatillo
Copy link
Member

What this PR does / why we need it:
Uplifts CAPI to v1.12.1, IPAM v1.12.0 and BMO v0.12.0

Fixes #

Checklist:

  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • E2E tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adilghaffardev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 18, 2025
@Sunnatillo
Copy link
Member Author

/cherry-pick release-1.12

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Sunnatillo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

1 similar comment
@Sunnatillo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@Sunnatillo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

BMH stuck in inspection

@Sunnatillo
Copy link
Member Author

versions:
- name: "v1.12.99"
value: "https://github.com/metal3-io/ip-address-manager/releases/download/v1.12.0-rc.0/ipam-components.yaml"
value: "https://github.com/metal3-io/ip-address-manager/releases/download/v1.12.0/ipam-components.yaml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: "https://github.com/metal3-io/ip-address-manager/releases/download/v1.12.0/ipam-components.yaml"
value: "https://github.com/metal3-io/ip-address-manager/releases/download/{go://github.com/metal3-io/ip-address-manager@v1.12}/ipam-components.yaml"

- name: metal3
type: IPAMProvider
versions:
- name: "v1.12.99"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of v1.12.99 lets use {go://github.com/metal3-io/[email protected]}

versions:
- name: "v1.12.99"
# Switch back to nightly builds once 1.12 stable is out. ("https://storage.googleapis.com/k8s-staging-cluster-api/components/nightly_main_${DATE}/core-components.yaml"
value: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.12.0-rc.1/core-components.yaml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- name: cluster-api
type: CoreProvider
versions:
- name: "v1.12.99"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{go://sigs.k8s.io/[email protected]}
lets add v1.13.99 for nightly build its main branch

@adilGhaffarDev
Copy link
Member

this also needs to be updated:

export CAPIRELEASE="v1.12.0-rc.1"

@Sunnatillo Sunnatillo force-pushed the Sunnatillo/uplift-capi-bmo-ipam branch from 3997494 to 328698b Compare December 23, 2025 09:58
@Sunnatillo Sunnatillo force-pushed the Sunnatillo/uplift-capi-bmo-ipam branch from 328698b to b142544 Compare December 23, 2025 10:44
@Sunnatillo
Copy link
Member Author

Sunnatillo commented Dec 23, 2025

@adilGhaffarDev I have created prepare release-v1.13 dev PR, where I addressed all the changes you asked. Lets keeps this one only for BMO IPAM CAPI uplift changes.

@Sunnatillo
Copy link
Member Author

Sunnatillo commented Dec 23, 2025

/test metal3-centos-e2e-integration-test-main

@Sunnatillo
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@Sunnatillo
Copy link
Member Author

/cc @lentzi90 @peppi-lotta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants