rewrite all-owners.sh script #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- First line of approvers were always mangled from data format change in CNCF CSV, fixed that. - Fixed looking up the emails with logic: - if email exists in the ALL-OWNERS, keep it - try locating it in the CNCF CSV, or in Git repos - The repos were cloned in current dir, clone them in /tmp. - Refactor the whole script into functions that can be understood, the logic in main was getting out of hand. Due prevervation of emails logic, the usage changes to `./all-owners.sh` as otherwise bash redirect `>` null the file before the script has chance to read it as input. Signed-off-by: Tuomo Tanskanen <[email protected]>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/L
Member
Author
|
/cc @kashifest @Rozzii |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the all-owners.sh due it growing complex and upstream data formats changing:
Due prevervation of emails logic, the usage changes to
./all-owners.shas otherwise bash redirect>null the file before the script has chance to read it as input. If redirect is used, then it will ignore the existing emails and dig up and email that was last used. Currently this results in one email changing.