-
Notifications
You must be signed in to change notification settings - Fork 40
🌱 Fix OSV-Scanner #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Fix OSV-Scanner #1152
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
2ab95ca to
28dbaac
Compare
|
/hold The scanner isn't working as it is supposed to even though it's green. I will look into this on thursday. |
28dbaac to
770a633
Compare
|
/unhold nvm, it works now |
770a633 to
3808eb4
Compare
|
/hold Nope, not working. I will continue with this on Thursday. There is some issue when trying to pass the config.toml to override Go version: |
01a9792 to
fe62308
Compare
|
/unhold |
fe62308 to
45d654b
Compare
|
/hold |
45d654b to
4b1f543
Compare
4b1f543 to
bbd3a4d
Compare
7ffd293 to
b5b7c30
Compare
7bf67ea to
d438bbb
Compare
Use the reusable workflow from project-infra for running OSV scanner. Signed-off-by: erjavaskivuori <[email protected]>
d438bbb to
415ef15
Compare
tuminoid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Once the project-infra PR merges, we can test this. Until then, keeping the hold.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
|
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @lentzi90 |
lentzi90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it: Adopt reusable workflow from project-infra to run OSV scanner.
Renamed the workflow with
scheduledprefix as it is a plan to add a workflow for all PRs too.