Skip to content

🌱 Bump CAPI to v1.10.0-rc.0 #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
metal3-io-bot merged 1 commit into from
Apr 10, 2025
Merged

🌱 Bump CAPI to v1.10.0-rc.0 #998

metal3-io-bot merged 1 commit into from
Apr 10, 2025

Conversation

@erjavaskivuori
Copy link
Member

@erjavaskivuori erjavaskivuori commented Apr 10, 2025

What this PR does / why we need it: Bump CAPI to v1.10.0-rc.0

@erjavaskivuori
Bump CAPI to v1.10.0-rc.0
f9ee0be 
Signed-off-by: erjavaskivuori <[email protected]>
@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 10, 2025
@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Apr 10, 2025

Hi @erjavaskivuori. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 10, 2025
@erjavaskivuori
Copy link
Member Author

erjavaskivuori commented Apr 10, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Apr 10, 2025

@erjavaskivuori: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lentzi90
Copy link
Member

lentzi90 commented Apr 10, 2025

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2025
@erjavaskivuori
Copy link
Member Author

erjavaskivuori commented Apr 10, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

lentzi90
lentzi90 reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks @erjavaskivuori !

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2025
smoshiur1237
smoshiur1237 reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you first PR. @erjavaskivuori
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2025
@erjavaskivuori
Copy link
Member Author

erjavaskivuori commented Apr 10, 2025

/retest

@metal3-io-bot metal3-io-bot merged commit 83a9948 into metal3-io:main Apr 10, 2025
13 checks passed
@metal3-io-bot metal3-io-bot deleted the bump-capi-1.10.0-rc.0 branch April 10, 2025 13:41
@metal3-io-bot metal3-io-bot added this to the IPAM - v1.10 milestone Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@peppi-lotta peppi-lotta Awaiting requested review from peppi-lotta

+1 more reviewer

@lentzi90 lentzi90 lentzi90 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

IPAM - v1.10

Development

Successfully merging this pull request may close these issues.

4 participants

@erjavaskivuori @metal3-io-bot @lentzi90 @smoshiur1237