Skip to content

Conversation

@elfosardo
Copy link
Member

Signed-off-by: Riccardo Pittau elfosardo@gmail.com

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 30, 2025
@elfosardo
Copy link
Member Author

/hold
wait for metal3-io/project-infra#1112 to merge

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2025
@elfosardo
Copy link
Member Author

/cc @tuminoid

@tuminoid
Copy link
Member

tuminoid commented Sep 30, 2025

Some test fixes needed:

--- FAIL: TestValidateIronic (0.00s)
    --- FAIL: TestValidateIronic/with_unsupported_version (0.00s)
        validation_test.go:343: 
            	Error Trace:	/home/runner/work/ironic-standalone-operator/ironic-standalone-operator/pkg/ironic/validation_test.go:343
            	Error:      	Error "version 42.42 is not supported, supported versions are 30.0, 31.0, 32.0, latest" does not contain "version 42.42 is not supported, supported versions are 30.0, 31.0, latest"
            	Test:       	TestValidateIronic/with_unsupported_version

@dtantsur
Copy link
Member

I think we've skipped the entire step of preparing the main branch before branching :-/ We need to update supported versions there, add missing tests, then, I guess, backport that commit.

@elfosardo
Copy link
Member Author

@dtantsur I just realized that there are discrepancies in main, specifically the new version of ironic has been added, but of course not the new release
we still need to update https://github.com/metal3-io/ironic-standalone-operator/blob/main/docs/releasing.md
this is still on hold, I will update main with what needs to be updated before merging this

@elfosardo
Copy link
Member Author

this is the update on main #390

@dtantsur
Copy link
Member

specifically the new version of ironic has been added, but of course not the new release

Correct, because I needed a version check, but the release itself did not exist at that point.

@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2025
@tuminoid
Copy link
Member

tuminoid commented Oct 1, 2025

@dtantsur I just realized that there are discrepancies in main, specifically the new version of ironic has been added, but of course not the new release we still need to update https://github.com/metal3-io/ironic-standalone-operator/blob/main/docs/releasing.md this is still on hold, I will update main with what needs to be updated before merging this

I think the IRSO process has gone bit off track versus the intended release process here. The branch etc should be created by the release automation, for example 0.6.0-beta.0 (beta cuts branch, alpha doesn't). Then you implement the CI support for the branch etc. Then you merge stuff there to cut the stable. As mentioned the 32.0 support should've also been in main before that.

Do we have some shortcomings in the release docs related to the workflow, or is it not working for IRSO?

@elfosardo
Copy link
Member Author

@tuminoid simply put, the release docs for IrSO is outdated
we need to add at least a mention to verify support for recent ironic-image releases, the rest kind of work, just need a refresh

@elfosardo
Copy link
Member Author

this #391 is needed before release preparation

@tuminoid
Copy link
Member

tuminoid commented Oct 1, 2025

@tuminoid simply put, the release docs for IrSO is outdated we need to add at least a mention to verify support for recent ironic-image releases, the rest kind of work, just need a refresh

Maybe we can amend verify-release.sh to check for these as well.

@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2025
Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2025
@elfosardo
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2025
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2025
@metal3-io-bot metal3-io-bot merged commit 0ece290 into metal3-io:release-0.6 Oct 2, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants