-
Notifications
You must be signed in to change notification settings - Fork 17
✨ Switch to Ironic 32.0 by default, prepare release-0.6 #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/hold |
|
/cc @tuminoid |
60394a0 to
fbecd32
Compare
|
Some test fixes needed: |
fbecd32 to
e173a91
Compare
|
I think we've skipped the entire step of preparing the main branch before branching :-/ We need to update supported versions there, add missing tests, then, I guess, backport that commit. |
|
@dtantsur I just realized that there are discrepancies in main, specifically the new version of ironic has been added, but of course not the new release |
|
this is the update on main #390 |
Correct, because I needed a version check, but the release itself did not exist at that point. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think the IRSO process has gone bit off track versus the intended release process here. The branch etc should be created by the release automation, for example 0.6.0-beta.0 (beta cuts branch, alpha doesn't). Then you implement the CI support for the branch etc. Then you merge stuff there to cut the stable. As mentioned the 32.0 support should've also been in main before that. Do we have some shortcomings in the release docs related to the workflow, or is it not working for IRSO? |
|
@tuminoid simply put, the release docs for IrSO is outdated |
|
this #391 is needed before release preparation |
Maybe we can amend verify-release.sh to check for these as well. |
Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
|
/unhold |
tuminoid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Riccardo Pittau elfosardo@gmail.com