Skip to content

chore(deps): update dependency ansible.netcommon to v8 - autoclosed #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
renovate wants to merge 1 commit into from
Closed

chore(deps): update dependency ansible.netcommon to v8 - autoclosed #1518

renovate wants to merge 1 commit into from

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Apr 14, 2025 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
ansible.netcommon galaxy-collection major 7.2.0 -> 8.2.0

Release Notes

ansible-collections/ansible.netcommon (ansible.netcommon)

v8.2.0

Compare Source

======

Minor Changes

  • Exposes new libssh option to configure key_exchange_algorithms. This requires ansible-pylibssh v1.3.0 or higher.

Bugfixes

  • Added support for private key passphrase in libssh connection plugin, when using encrypted private keys specified by the C(ansible_private_key_file) attribute.
  • Avoid legacy imports deprecated in ansible-core 2.20 (#​720).
  • Avoid merging module_defaults for all ansible.netcommon.grpc_* modules.
  • Set libssh logging level to DEBUG when Ansible verbosity is greater than 3, to aid in troubleshooting connection issues.

v8.1.0

Compare Source

======

Minor Changes

  • Changes to supplement direct execution of Ansible module in validate_config(utils.py) and _patch_update_module(network.py) added.
  • Override new 2.19.1+ AnsibleModule._record_module_result hook in network action plugin to bypass module result serialization when direct execution is enabled

Bugfixes

  • Improved error handling in DirectExecutionModule._record_module_result method for better compatibility with core<=2.18

v8.0.1

Compare Source

======

Bugfixes

  • (#​633) Fixed typo in ansible.netcommon.telnet parameter crlf (was clrf by mistake)
  • netconf - Adds check for netconf session_close RPC happens only if connection is alive.

v8.0.0

Compare Source

======

Release Summary

With this release, the minimum required version of ansible-core for this collection is 2.16.0. The last version known to be compatible with ansible-core versions below 2.16 is v7.2.0.

Major Changes

  • Bumping requires_ansible to >=2.16.0, since previous ansible-core versions are EoL now.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 14, 2025
@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Apr 14, 2025

Hi @renovate[bot]. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2025
@Rozzii
Copy link
Member

Rozzii commented Apr 14, 2025

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2025
@Rozzii
Copy link
Member

Rozzii commented Apr 14, 2025

/test metal3-centos-e2e-integration-test-release-1-9
/test metal3-dev-env-integration-test-ubuntu-main

@elfosardo
Copy link
Member

elfosardo commented Apr 15, 2025 •
edited
Loading

this could break a lot of things, AFAIK ansible.netcommon 8 does not support ansible-core 2.15.x

https://galaxy.ansible.com/ui/repo/published/ansible/netcommon/
Requires Ansible >=2.16.0

@elfosardo
Copy link
Member

elfosardo commented Apr 15, 2025

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2025
@renovate renovate bot force-pushed the renovate/ansible.netcommon-8.x branch from 4e48af4 to 364021e Compare July 2, 2025 06:29
@renovate renovate bot force-pushed the renovate/ansible.netcommon-8.x branch from 364021e to 36272dc Compare August 14, 2025 15:09
@renovate renovate bot force-pushed the renovate/ansible.netcommon-8.x branch from 36272dc to 13e3225 Compare November 6, 2025 07:15
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2025
@tuminoid
Copy link
Member

tuminoid commented Dec 2, 2025

Whats the play here @elfosardo ? this has been on hold for months.

@elfosardo
Copy link
Member

elfosardo commented Dec 5, 2025

/unhold
ansible-core is now on 2.17 so we can unhold this

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2025
@tuminoid
Copy link
Member

tuminoid commented Dec 5, 2025

Needs rebase

@elfosardo
Copy link
Member

elfosardo commented Dec 5, 2025

@tuminoid I can't rebase it, I don't haveenough powers to push the update directly here

@tuminoid
Copy link
Member

tuminoid commented Dec 6, 2025

@tuminoid I can't rebase it, I don't haveenough powers to push the update directly here

Oh right, this is Renovate's PR. There is a box in description we can tick to rebase. Lemme clicketi click that.

@renovate renovate bot force-pushed the renovate/ansible.netcommon-8.x branch from 13e3225 to 47fe8fb Compare December 6, 2025 10:43
@renovate renovate bot changed the title Update dependency ansible.netcommon to v8 chore(deps): update dependency ansible.netcommon to v8 Dec 6, 2025
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2025
@tuminoid
Copy link
Member

tuminoid commented Dec 6, 2025

/unhold ansible-core is now on 2.17 so we can unhold this

Btw, is this true for all supported OS? Ubuntu 22/24 and Centos 9/10, and SLES 15?

/test ?

@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Dec 6, 2025

@tuminoid: The following commands are available to trigger required jobs:

/test markdownlint

/test metal3-centos-e2e-integration-test-release-1-11

/test metal3-dev-env-integration-test-ubuntu-main

/test shellcheck

The following commands are available to trigger optional jobs:

/test metal3-bml-integration-test-centos

/test metal3-centos-e2e-basic-test-main

/test metal3-centos-e2e-basic-test-release-1-10

/test metal3-centos-e2e-basic-test-release-1-11

/test metal3-centos-e2e-basic-test-release-1-9

/test metal3-centos-e2e-capi-md-test-main

/test metal3-centos-e2e-feature-test-main-features

/test metal3-centos-e2e-feature-test-main-pivoting

/test metal3-centos-e2e-feature-test-main-remediation

/test metal3-centos-e2e-feature-test-release-1-10-features

/test metal3-centos-e2e-feature-test-release-1-10-pivoting

/test metal3-centos-e2e-feature-test-release-1-10-remediation

/test metal3-centos-e2e-feature-test-release-1-11-features

/test metal3-centos-e2e-feature-test-release-1-11-pivoting

/test metal3-centos-e2e-feature-test-release-1-11-remediation

/test metal3-centos-e2e-feature-test-release-1-9-features

/test metal3-centos-e2e-feature-test-release-1-9-pivoting

/test metal3-centos-e2e-feature-test-release-1-9-remediation

/test metal3-centos-e2e-integration-k8s-pre-release-test-main

/test metal3-centos-e2e-integration-test-main

/test metal3-centos-e2e-integration-test-release-1-10

/test metal3-centos-e2e-integration-test-release-1-9

/test metal3-dev-env-integration-test-centos-main

/test metal3-dev-env-integration-test-centos-release-1-10

/test metal3-dev-env-integration-test-centos-release-1-11

/test metal3-dev-env-integration-test-centos-release-1-9

/test metal3-dev-env-integration-test-ubuntu-release-1-10

/test metal3-dev-env-integration-test-ubuntu-release-1-11

/test metal3-dev-env-integration-test-ubuntu-release-1-9

/test metal3-e2e-1-29-1-30-upgrade-test-main

/test metal3-e2e-1-29-1-30-upgrade-test-release-1-10

/test metal3-e2e-1-29-1-30-upgrade-test-release-1-11

/test metal3-e2e-1-29-1-30-upgrade-test-release-1-9

/test metal3-e2e-clusterctl-upgrade-test-main

/test metal3-e2e-clusterctl-upgrade-test-release-1-10

/test metal3-e2e-clusterctl-upgrade-test-release-1-11

/test metal3-e2e-clusterctl-upgrade-test-release-1-9

/test metal3-e2e-conformance-test-main

/test metal3-ubuntu-e2e-basic-test-main

/test metal3-ubuntu-e2e-basic-test-release-1-10

/test metal3-ubuntu-e2e-basic-test-release-1-11

/test metal3-ubuntu-e2e-basic-test-release-1-9

/test metal3-ubuntu-e2e-capi-md-test-main

/test metal3-ubuntu-e2e-feature-test-main-features

/test metal3-ubuntu-e2e-feature-test-main-pivoting

/test metal3-ubuntu-e2e-feature-test-main-remediation

/test metal3-ubuntu-e2e-feature-test-release-1-10-features

/test metal3-ubuntu-e2e-feature-test-release-1-10-pivoting

/test metal3-ubuntu-e2e-feature-test-release-1-10-remediation

/test metal3-ubuntu-e2e-feature-test-release-1-11-features

/test metal3-ubuntu-e2e-feature-test-release-1-11-pivoting

/test metal3-ubuntu-e2e-feature-test-release-1-11-remediation

/test metal3-ubuntu-e2e-feature-test-release-1-9-features

/test metal3-ubuntu-e2e-feature-test-release-1-9-pivoting

/test metal3-ubuntu-e2e-feature-test-release-1-9-remediation

/test metal3-ubuntu-e2e-integration-k8s-pre-release-test-main

/test metal3-ubuntu-e2e-integration-test-main

/test metal3-ubuntu-e2e-integration-test-release-1-10

/test metal3-ubuntu-e2e-integration-test-release-1-11

/test metal3-ubuntu-e2e-integration-test-release-1-9
Details

In response to this:

/unhold ansible-core is now on 2.17 so we can unhold this

Btw, is this true for all supported OS? Ubuntu 22/24 and Centos 9/10, and SLES 15?

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member

tuminoid commented Dec 6, 2025

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-centos-e2e-integration-test-release-1-11
/test metal3-dev-env-integration-test-centos-main

Rozzii
Rozzii reviewed Dec 8, 2025
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold
Which distros are we still waiting for @elfosardo ?

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2025
@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Dec 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2025
@renovate renovate bot changed the title chore(deps): update dependency ansible.netcommon to v8 chore(deps): update dependency ansible.netcommon to v8 - autoclosed Dec 15, 2025
@renovate renovate bot closed this Dec 15, 2025
@renovate renovate bot deleted the renovate/ansible.netcommon-8.x branch December 15, 2025 09:06
@tuminoid
Copy link
Member

tuminoid commented Dec 15, 2025

Renovate config got updated, it closed this? Hmm, let's see if it reopens new one or what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rozzii Rozzii Rozzii left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@metal3-io-bot @Rozzii @elfosardo @tuminoid