Skip to content

Conversation

@tuminoid
Copy link
Member

We have now yamllint workflow here, which has github actions that need to be kept up to date. Add dependabot config for take care of that.

We have now yamllint workflow here, which has github actions that need
to be kept up to date. Add dependabot config for take care of that.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 11, 2025
@tuminoid
Copy link
Member Author

/cc @adilGhaffarDev @kashifest @smoshiur1237
/override metal3-centos-e2e-integration-test-release-1-11 metal3-dev-env-integration-test-ubuntu-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-11, metal3-dev-env-integration-test-ubuntu-main

Details

In response to this:

/cc @adilGhaffarDev @kashifest @smoshiur1237
/override metal3-centos-e2e-integration-test-release-1-11 metal3-dev-env-integration-test-ubuntu-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2025
@tuminoid
Copy link
Member Author

/hold

Renovate activated for the same, wtf. It has not updated workflows for long time.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2025
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which one should we take..

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can remove the renovate.json then and take this instead? We use dependabot in all other repos so it would be weird to use renovate here.
/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2025
@tuminoid
Copy link
Member Author

Perhaps we can remove the renovate.json then and take this instead? We use dependabot in all other repos so it would be weird to use renovate here. /approve

We use Renovate here for things Dependabot cannot handle. I think I will just streamline Dependabot to handle the actions etc stuff it can do, and limit renovate to to things Dependabot cannot handle. Renovate has been too unreliable in this repo, for unknown reasons for long time.

@tuminoid
Copy link
Member Author

I will unhold when I've sorted out the above.

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lentzi90 the use case are a bit different here, renovate was chosen here to keep the binaries up to date which dependabot cannot, but sadly renovate is not doing that for some reason, I will check renovate workflow.

@kashifest
Copy link
Member

We use Renovate here for things Dependabot cannot handle. I think I will just streamline Dependabot to handle the actions etc stuff it can do, and limit renovate to to things Dependabot cannot handle. Renovate has been too unreliable in this repo, for unknown reasons for long time.

We commented at the same time, I will check the renovate here @tuminoid

@tuminoid
Copy link
Member Author

#1611 is merged, let's see if renovate performs as expected. If not, we'll rip it out of renovate and merge this.

@Sunnatillo
Copy link
Member

/test ?

Just testing

@metal3-io-bot
Copy link
Collaborator

@Sunnatillo: The following commands are available to trigger required jobs:

/test markdownlint
/test metal3-centos-e2e-integration-test-release-1-11
/test metal3-centos-e2e-integration-test-release-1-12
/test metal3-dev-env-integration-test-ubuntu-main
/test shellcheck

The following commands are available to trigger optional jobs:

/test metal3-bml-integration-test-centos
/test metal3-centos-e2e-basic-test-main
/test metal3-centos-e2e-basic-test-release-1-10
/test metal3-centos-e2e-basic-test-release-1-11
/test metal3-centos-e2e-basic-test-release-1-12
/test metal3-centos-e2e-basic-test-release-1-9
/test metal3-centos-e2e-capi-md-test-main
/test metal3-centos-e2e-feature-test-main-features
/test metal3-centos-e2e-feature-test-main-pivoting
/test metal3-centos-e2e-feature-test-main-remediation
/test metal3-centos-e2e-feature-test-release-1-10-features
/test metal3-centos-e2e-feature-test-release-1-10-pivoting
/test metal3-centos-e2e-feature-test-release-1-10-remediation
/test metal3-centos-e2e-feature-test-release-1-11-features
/test metal3-centos-e2e-feature-test-release-1-11-pivoting
/test metal3-centos-e2e-feature-test-release-1-11-remediation
/test metal3-centos-e2e-feature-test-release-1-12-features
/test metal3-centos-e2e-feature-test-release-1-12-pivoting
/test metal3-centos-e2e-feature-test-release-1-12-remediation
/test metal3-centos-e2e-feature-test-release-1-9-features
/test metal3-centos-e2e-feature-test-release-1-9-pivoting
/test metal3-centos-e2e-feature-test-release-1-9-remediation
/test metal3-centos-e2e-integration-k8s-pre-release-test-main
/test metal3-centos-e2e-integration-test-main
/test metal3-centos-e2e-integration-test-release-1-10
/test metal3-centos-e2e-integration-test-release-1-9
/test metal3-dev-env-integration-test-centos-main
/test metal3-dev-env-integration-test-centos-release-1-10
/test metal3-dev-env-integration-test-centos-release-1-11
/test metal3-dev-env-integration-test-centos-release-1-12
/test metal3-dev-env-integration-test-centos-release-1-9
/test metal3-dev-env-integration-test-ubuntu-release-1-10
/test metal3-dev-env-integration-test-ubuntu-release-1-11
/test metal3-dev-env-integration-test-ubuntu-release-1-12
/test metal3-dev-env-integration-test-ubuntu-release-1-9
/test metal3-e2e-1-29-1-30-upgrade-test-main
/test metal3-e2e-1-29-1-30-upgrade-test-release-1-10
/test metal3-e2e-1-29-1-30-upgrade-test-release-1-11
/test metal3-e2e-1-29-1-30-upgrade-test-release-1-12
/test metal3-e2e-1-29-1-30-upgrade-test-release-1-9
/test metal3-e2e-clusterctl-upgrade-test-main
/test metal3-e2e-clusterctl-upgrade-test-release-1-10
/test metal3-e2e-clusterctl-upgrade-test-release-1-11
/test metal3-e2e-clusterctl-upgrade-test-release-1-12
/test metal3-e2e-clusterctl-upgrade-test-release-1-9
/test metal3-e2e-conformance-test-main
/test metal3-ubuntu-e2e-basic-test-main
/test metal3-ubuntu-e2e-basic-test-release-1-10
/test metal3-ubuntu-e2e-basic-test-release-1-11
/test metal3-ubuntu-e2e-basic-test-release-1-12
/test metal3-ubuntu-e2e-basic-test-release-1-9
/test metal3-ubuntu-e2e-capi-md-test-main
/test metal3-ubuntu-e2e-feature-test-main-features
/test metal3-ubuntu-e2e-feature-test-main-pivoting
/test metal3-ubuntu-e2e-feature-test-main-remediation
/test metal3-ubuntu-e2e-feature-test-release-1-10-features
/test metal3-ubuntu-e2e-feature-test-release-1-10-pivoting
/test metal3-ubuntu-e2e-feature-test-release-1-10-remediation
/test metal3-ubuntu-e2e-feature-test-release-1-11-features
/test metal3-ubuntu-e2e-feature-test-release-1-11-pivoting
/test metal3-ubuntu-e2e-feature-test-release-1-11-remediation
/test metal3-ubuntu-e2e-feature-test-release-1-12-features
/test metal3-ubuntu-e2e-feature-test-release-1-12-pivoting
/test metal3-ubuntu-e2e-feature-test-release-1-12-remediation
/test metal3-ubuntu-e2e-feature-test-release-1-9-features
/test metal3-ubuntu-e2e-feature-test-release-1-9-pivoting
/test metal3-ubuntu-e2e-feature-test-release-1-9-remediation
/test metal3-ubuntu-e2e-integration-k8s-pre-release-test-main
/test metal3-ubuntu-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-release-1-10
/test metal3-ubuntu-e2e-integration-test-release-1-11
/test metal3-ubuntu-e2e-integration-test-release-1-12
/test metal3-ubuntu-e2e-integration-test-release-1-9
Details

In response to this:

/test ?

Just testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member Author

CI testing.
/test metal3-centos-e2e-integration-test-release-1-12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants