-
Notifications
You must be signed in to change notification settings - Fork 128
add dependabot config #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add dependabot config #1609
Conversation
We have now yamllint workflow here, which has github actions that need to be kept up to date. Add dependabot config for take care of that. Signed-off-by: Tuomo Tanskanen <[email protected]>
|
/cc @adilGhaffarDev @kashifest @smoshiur1237 |
|
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-11, metal3-dev-env-integration-test-ubuntu-main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
adilGhaffarDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/hold Renovate activated for the same, wtf. It has not updated workflows for long time. |
smoshiur1237
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one should we take..
lentzi90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can remove the renovate.json then and take this instead? We use dependabot in all other repos so it would be weird to use renovate here.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adilGhaffarDev, lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We use Renovate here for things Dependabot cannot handle. I think I will just streamline Dependabot to handle the actions etc stuff it can do, and limit renovate to to things Dependabot cannot handle. Renovate has been too unreliable in this repo, for unknown reasons for long time. |
|
I will unhold when I've sorted out the above. |
kashifest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lentzi90 the use case are a bit different here, renovate was chosen here to keep the binaries up to date which dependabot cannot, but sadly renovate is not doing that for some reason, I will check renovate workflow.
We commented at the same time, I will check the renovate here @tuminoid |
|
#1611 is merged, let's see if renovate performs as expected. If not, we'll rip it out of renovate and merge this. |
|
/test ? Just testing |
|
@Sunnatillo: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
CI testing. |
We have now yamllint workflow here, which has github actions that need to be kept up to date. Add dependabot config for take care of that.