Skip to content

🌱 remove ipam related temp changes #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
peppi-lotta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 remove ipam related temp changes #1615

peppi-lotta wants to merge 1 commit into from

Conversation

@peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Dec 22, 2025

When IPAM was made into a provider for CAPI the way is deployed was changed. This required a different way of deploying in older and newer versions. Now that v1.9.x is no longer tested, these temporary changes can be removed.

@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rozzii for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 22, 2025
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/remove-ipam-related-temp-changes branch from dbffc79 to 32d9577 Compare December 22, 2025 13:53
@Sunnatillo
Copy link
Member

Sunnatillo commented Dec 22, 2025

/test metal3-centos-e2e-integration-test-release-1-12 metal3-centos-e2e-integration-test-release-1-11 metal3-dev-env-integration-test-ubuntu-main

@Sunnatillo
Copy link
Member

Sunnatillo commented Dec 22, 2025

You are pushing commit of previous PR to this one as well:
https://github.com/metal3-io/metal3-dev-env/pull/1613/commits

@peppi-lotta
Remove IPAM related temporary changes
fa73eea 
When IPAM was made into a provider for CAPI
the way it is deployed was changed. This required a different way of
deploying in older and newer version. Now that v1.9.x is no
longer tested, these temporary changes can be removed.

Signed-off-by: peppi-lotta <[email protected]>
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/remove-ipam-related-temp-changes branch from 32d9577 to fa73eea Compare December 23, 2025 07:16
@peppi-lotta
Copy link
Member Author

peppi-lotta commented Dec 23, 2025

/test metal3-centos-e2e-integration-test-release-1-12 metal3-centos-e2e-integration-test-release-1-11 metal3-dev-env-integration-test-ubuntu-main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lentzi90 lentzi90 Awaiting requested review from lentzi90

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees

No one assigned

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peppi-lotta @metal3-io-bot @Sunnatillo