Skip to content

Bump k8s to v1.35 for pre-release test #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kashifest wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump k8s to v1.35 for pre-release test #1208

kashifest wants to merge 1 commit into from

Conversation

@kashifest
Copy link
Member

@kashifest kashifest commented Dec 18, 2025

  • Bumps image building
  • pre-release test
  • n+3 test

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 18, 2025
@kashifest kashifest mentioned this pull request Dec 18, 2025
Open
adilGhaffarDev
adilGhaffarDev approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2025
@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adilGhaffarDev
Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sunnatillo
Copy link
Member

Sunnatillo commented Dec 18, 2025

/test metal3-node-image-building

@Sunnatillo
Copy link
Member

Sunnatillo commented Dec 18, 2025

I would not uplift n+3 and pre-release test in a single PR. Better would be to properly test new k8s version via image building pipeline and respectively uplift n+3, k8s uprade tests together with their workflow from cicd -> project infra -> camp3.
We have quite many jobs, I believe we should uplift things on separate PRs for separate tests to avoid accidentally breaking them.

@Sunnatillo
Copy link
Member

Sunnatillo commented Dec 18, 2025

/test metal3-node-image-building

I will stop the test, since it is not testing correctly. and trigger manual test.

@Sunnatillo
Copy link
Member

Sunnatillo commented Dec 18, 2025

here is thesting correct versions:
https://jenkins.nordix.org/view/Metal3/job/metal3-node-image-building/125/

@adilGhaffarDev
Copy link
Member

adilGhaffarDev commented Dec 18, 2025

I would not uplift n+3 and pre-release test in a single PR. Better would be to properly test new k8s version via image building pipeline and respectively uplift n+3, k8s uprade tests together with their workflow from cicd -> project infra -> camp3. We have quite many jobs, I believe we should uplift things on separate PRs for separate tests to avoid accidentally breaking them.

agree, lets merge this one first: #1207, after that we can merge this one with cicd

@adilGhaffarDev
Copy link
Member

adilGhaffarDev commented Dec 18, 2025

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2025
@kashifest
Copy link
Member Author

kashifest commented Dec 18, 2025

ok I am fine with it

@kashifest kashifest force-pushed the bump/pre-release-k8s branch from 430f4a6 to 16d298c Compare December 18, 2025 12:30
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2025
@kashifest kashifest changed the title Bump k8s to v1.35 Bump k8s to v1.35 for pre-release test Dec 18, 2025
@kashifest
Copy link
Member Author

kashifest commented Dec 18, 2025

/test ?

@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Dec 18, 2025

@kashifest: The following commands are available to trigger required jobs:

/test check-prow-config

/test markdownlint

/test metal3-ubuntu-e2e-integration-test-main

/test shellcheck

/test spellcheck

The following commands are available to trigger optional jobs:

/test metal3-bml-integration-test-centos

/test metal3-centos-e2e-basic-test-main

/test metal3-centos-e2e-basic-test-release-1-10

/test metal3-centos-e2e-basic-test-release-1-11

/test metal3-centos-e2e-basic-test-release-1-9

/test metal3-centos-e2e-capi-md-test-main

/test metal3-centos-e2e-feature-test-main-features

/test metal3-centos-e2e-feature-test-main-pivoting

/test metal3-centos-e2e-feature-test-main-remediation

/test metal3-centos-e2e-feature-test-release-1-10-features

/test metal3-centos-e2e-feature-test-release-1-10-pivoting

/test metal3-centos-e2e-feature-test-release-1-10-remediation

/test metal3-centos-e2e-feature-test-release-1-11-features

/test metal3-centos-e2e-feature-test-release-1-11-pivoting

/test metal3-centos-e2e-feature-test-release-1-11-remediation

/test metal3-centos-e2e-feature-test-release-1-9-features

/test metal3-centos-e2e-feature-test-release-1-9-pivoting

/test metal3-centos-e2e-feature-test-release-1-9-remediation

/test metal3-centos-e2e-integration-k8s-pre-release-test-main

/test metal3-centos-e2e-integration-test-main

/test metal3-centos-e2e-integration-test-release-1-10

/test metal3-centos-e2e-integration-test-release-1-11

/test metal3-centos-e2e-integration-test-release-1-9

/test metal3-ci-image-building

/test metal3-dev-env-integration-test-centos-main

/test metal3-dev-env-integration-test-centos-release-1-10

/test metal3-dev-env-integration-test-centos-release-1-11

/test metal3-dev-env-integration-test-centos-release-1-9

/test metal3-dev-env-integration-test-ubuntu-main

/test metal3-dev-env-integration-test-ubuntu-release-1-10

/test metal3-dev-env-integration-test-ubuntu-release-1-11

/test metal3-dev-env-integration-test-ubuntu-release-1-9

/test metal3-e2e-1-29-1-30-upgrade-test-main

/test metal3-e2e-1-29-1-30-upgrade-test-release-1-10

/test metal3-e2e-1-29-1-30-upgrade-test-release-1-11

/test metal3-e2e-1-29-1-30-upgrade-test-release-1-9

/test metal3-e2e-clusterctl-upgrade-test-main

/test metal3-e2e-clusterctl-upgrade-test-release-1-10

/test metal3-e2e-clusterctl-upgrade-test-release-1-11

/test metal3-e2e-clusterctl-upgrade-test-release-1-9

/test metal3-e2e-conformance-test-main

/test metal3-fullstack-build

/test metal3-node-image-building

/test metal3-ubuntu-e2e-basic-test-main

/test metal3-ubuntu-e2e-basic-test-release-1-10

/test metal3-ubuntu-e2e-basic-test-release-1-11

/test metal3-ubuntu-e2e-basic-test-release-1-9

/test metal3-ubuntu-e2e-capi-md-test-main

/test metal3-ubuntu-e2e-feature-test-main-features

/test metal3-ubuntu-e2e-feature-test-main-pivoting

/test metal3-ubuntu-e2e-feature-test-main-remediation

/test metal3-ubuntu-e2e-feature-test-release-1-10-features

/test metal3-ubuntu-e2e-feature-test-release-1-10-pivoting

/test metal3-ubuntu-e2e-feature-test-release-1-10-remediation

/test metal3-ubuntu-e2e-feature-test-release-1-11-features

/test metal3-ubuntu-e2e-feature-test-release-1-11-pivoting

/test metal3-ubuntu-e2e-feature-test-release-1-11-remediation

/test metal3-ubuntu-e2e-feature-test-release-1-9-features

/test metal3-ubuntu-e2e-feature-test-release-1-9-pivoting

/test metal3-ubuntu-e2e-feature-test-release-1-9-remediation

/test metal3-ubuntu-e2e-integration-k8s-pre-release-test-main

/test metal3-ubuntu-e2e-integration-test-release-1-10

/test metal3-ubuntu-e2e-integration-test-release-1-11

/test metal3-ubuntu-e2e-integration-test-release-1-9

Use /test all to run the following jobs that were automatically triggered:

check-prow-config

shellcheck
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kashifest kashifest force-pushed the bump/pre-release-k8s branch 3 times, most recently from 7e1425b to 533619b Compare December 18, 2025 12:35
@kashifest
Bump k8s to v1.35
efe72ad 
- Bumps image building
- pre-release test

Signed-off-by: Kashif Khan <[email protected]>
@kashifest kashifest force-pushed the bump/pre-release-k8s branch from 533619b to efe72ad Compare December 18, 2025 12:36
@kashifest
Copy link
Member Author

kashifest commented Dec 18, 2025

/test metal3-centos-e2e-integration-k8s-pre-release-test-main

@kashifest
Copy link
Member Author

kashifest commented Dec 19, 2025

/test metal3-ubuntu-e2e-integration-k8s-pre-release-test-main

@adilGhaffarDev
Copy link
Member

adilGhaffarDev commented Dec 22, 2025

/test metal3-centos-e2e-integration-k8s-pre-release-test-main
/test metal3-ubuntu-e2e-integration-k8s-pre-release-test-main

@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Dec 22, 2025

@kashifest: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-centos-e2e-integration-k8s-pre-release-test-main efe72ad link false /test metal3-centos-e2e-integration-k8s-pre-release-test-main
metal3-ubuntu-e2e-integration-k8s-pre-release-test-main efe72ad link false /test metal3-ubuntu-e2e-integration-k8s-pre-release-test-main

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Dec 22, 2025

@kashifest: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-centos-e2e-integration-k8s-pre-release-test-main efe72ad link false /test metal3-centos-e2e-integration-k8s-pre-release-test-main
metal3-ubuntu-e2e-integration-k8s-pre-release-test-main efe72ad link false /test metal3-ubuntu-e2e-integration-k8s-pre-release-test-main
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@adilGhaffarDev
Copy link
Member

adilGhaffarDev commented Dec 23, 2025

/override metal3-centos-e2e-integration-k8s-pre-release-test-main
/override metal3-ubuntu-e2e-integration-k8s-pre-release-test-main

this needs to be merged, we cannot test the pipeline before merging.

@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Dec 23, 2025

@adilGhaffarDev: adilGhaffarDev unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

Details

In response to this:

/override metal3-centos-e2e-integration-k8s-pre-release-test-main
/override metal3-ubuntu-e2e-integration-k8s-pre-release-test-main

this needs to be merged, we cannot test the pipeline before merging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

adilGhaffarDev
adilGhaffarDev reviewed Dec 23, 2025
View reviewed changes
Copy link
Member

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold
cc @Sunnatillo

@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

1 more reviewer

@adilGhaffarDev adilGhaffarDev adilGhaffarDev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kashifest @metal3-io-bot @Sunnatillo @adilGhaffarDev