Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prow: Define jobs per release branch #893

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Prow: Define jobs per release branch #893

merged 1 commit into from
Nov 8, 2024
+1,161 −6

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Nov 7, 2024

In the previous PR I kept "common" tests in the main file. This PR splits them up so that each release branch has all its own tests clearly defined in a separate file. Easier to keep track of at the cost of some duplication.

@lentzi90
Copy link
Member Author

lentzi90 commented Nov 7, 2024

/override metal3-ubuntu-e2e-integration-test-main
Irrelevant...

/cc @tuminoid

@lentzi90
Copy link
Member Author

lentzi90 commented Nov 7, 2024

/test ?

@metal3-io-bot
Copy link
Collaborator

@lentzi90: The following commands are available to trigger required jobs:

  • /test check-prow-config
  • /test markdownlint
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck
  • /test spellcheck

The following commands are available to trigger optional jobs:

  • /test metal3-bml-integration-test-centos
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-basic-test-release-1-6
  • /test metal3-centos-e2e-basic-test-release-1-7
  • /test metal3-centos-e2e-basic-test-release-1-8
  • /test metal3-centos-e2e-feature-test-main-features
  • /test metal3-centos-e2e-feature-test-main-pivoting
  • /test metal3-centos-e2e-feature-test-main-remediation
  • /test metal3-centos-e2e-feature-test-release-1-6-features
  • /test metal3-centos-e2e-feature-test-release-1-6-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-6-remediation
  • /test metal3-centos-e2e-feature-test-release-1-7-features
  • /test metal3-centos-e2e-feature-test-release-1-7-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-7-remediation
  • /test metal3-centos-e2e-feature-test-release-1-8-features
  • /test metal3-centos-e2e-feature-test-release-1-8-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-8-remediation
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-centos-e2e-integration-test-release-1-6
  • /test metal3-centos-e2e-integration-test-release-1-7
  • /test metal3-centos-e2e-integration-test-release-1-8
  • /test metal3-dev-env-integration-test-centos-main
  • /test metal3-dev-env-integration-test-centos-release-1-6
  • /test metal3-dev-env-integration-test-centos-release-1-7
  • /test metal3-dev-env-integration-test-centos-release-1-8
  • /test metal3-dev-env-integration-test-ubuntu-main
  • /test metal3-dev-env-integration-test-ubuntu-release-1-6
  • /test metal3-dev-env-integration-test-ubuntu-release-1-7
  • /test metal3-dev-env-integration-test-ubuntu-release-1-8
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-6
  • /test metal3-e2e-1-29-1-30-upgrade-test-main
  • /test metal3-e2e-1-29-1-30-upgrade-test-release-1-7
  • /test metal3-e2e-1-29-1-30-upgrade-test-release-1-8
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-6
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-7
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-8
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-basic-test-release-1-6
  • /test metal3-ubuntu-e2e-basic-test-release-1-7
  • /test metal3-ubuntu-e2e-basic-test-release-1-8
  • /test metal3-ubuntu-e2e-feature-test-main-features
  • /test metal3-ubuntu-e2e-feature-test-main-pivoting
  • /test metal3-ubuntu-e2e-feature-test-main-remediation
  • /test metal3-ubuntu-e2e-feature-test-release-1-6-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-6-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-6-remediation
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-remediation
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-remediation
  • /test metal3-ubuntu-e2e-integration-test-release-1-6
  • /test metal3-ubuntu-e2e-integration-test-release-1-7
  • /test metal3-ubuntu-e2e-integration-test-release-1-8

Use /test all to run the following jobs that were automatically triggered:

  • check-prow-config

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lentzi90
Copy link
Member Author

lentzi90 commented Nov 7, 2024

/test check-prow-config

@lentzi90
Copy link
Member Author

lentzi90 commented Nov 7, 2024

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tuminoid
tuminoid reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Maybe add a README section somewhere about the new layout and simple examples about adding/removing a release?

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024
@lentzi90
Prow: Define jobs per release branch
92dd187 
In the previous PR I kept "common" tests in the main file. This PR
splits them up so that each release branch has all its own tests clearly
defined in a separate file. Easier to keep track of at the cost of some
duplication.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/prow-jobs-per-branch branch from e33a8f9 to 92dd187 Compare November 7, 2024 11:54
@metal3-io-bot metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 7, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Nov 7, 2024

Added a section to the readme now 🙂

@tuminoid
Copy link
Member

tuminoid commented Nov 7, 2024

Lovely, thanks!

@tuminoid
Copy link
Member

tuminoid commented Nov 7, 2024

/override metal3-ubuntu-e2e-integration-test-main
/cc @Rozzii

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main
/cc @Rozzii

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sunnatillo
Sunnatillo approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sunnatillo,tuminoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sunnatillo
Sunnatillo reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@metal3-io-bot metal3-io-bot merged commit c3ae4a4 into metal3-io:main Nov 8, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/prow-jobs-per-branch branch November 8, 2024 07:40
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key baremetal-operator-release-0.5.yaml using file prow/config/jobs/metal3-io/baremetal-operator-release-0.5.yaml
  • key baremetal-operator-release-0.6.yaml using file prow/config/jobs/metal3-io/baremetal-operator-release-0.6.yaml
  • key baremetal-operator-release-0.8.yaml using file prow/config/jobs/metal3-io/baremetal-operator-release-0.8.yaml
  • key baremetal-operator.yaml using file prow/config/jobs/metal3-io/baremetal-operator.yaml
  • key cluster-api-provider-metal3.yaml using file prow/config/jobs/metal3-io/cluster-api-provider-metal3.yaml
  • key cluster-api-provier-metal3-release-1.6.yaml using file prow/config/jobs/metal3-io/cluster-api-provier-metal3-release-1.6.yaml
  • key cluster-api-provier-metal3-release-1.7.yaml using file prow/config/jobs/metal3-io/cluster-api-provier-metal3-release-1.7.yaml
  • key cluster-api-provier-metal3-release-1.8.yaml using file prow/config/jobs/metal3-io/cluster-api-provier-metal3-release-1.8.yaml
  • key ip-address-manager-release-1.6.yaml using file prow/config/jobs/metal3-io/ip-address-manager-release-1.6.yaml
  • key ip-address-manager-release-1.7.yaml using file prow/config/jobs/metal3-io/ip-address-manager-release-1.7.yaml
  • key ip-address-manager-release-1.8.yaml using file prow/config/jobs/metal3-io/ip-address-manager-release-1.8.yaml
  • key ip-address-manager.yaml using file prow/config/jobs/metal3-io/ip-address-manager.yaml
  • key ironic-image-release-24.0.yaml using file prow/config/jobs/metal3-io/ironic-image-release-24.0.yaml
  • key ironic-image-release-24.1.yaml using file prow/config/jobs/metal3-io/ironic-image-release-24.1.yaml
  • key ironic-image-release-25.0.yaml using file prow/config/jobs/metal3-io/ironic-image-release-25.0.yaml
  • key ironic-image-release-26.0.yaml using file prow/config/jobs/metal3-io/ironic-image-release-26.0.yaml
  • key ironic-image.yaml using file prow/config/jobs/metal3-io/ironic-image.yaml

In response to this:

In the previous PR I kept "common" tests in the main file. This PR splits them up so that each release branch has all its own tests clearly defined in a separate file. Easier to keep track of at the cost of some duplication.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo approved these changes

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Awaiting requested review from Rozzii

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lentzi90 @metal3-io-bot @tuminoid @Sunnatillo