Skip to content

Eager http detection #3330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Jul 14, 2025
Merged

Conversation

Razz4780
Copy link
Contributor

@Razz4780 Razz4780 commented May 22, 2025

Contains changes required for mirroring on the HTTP level:

Implementation changes

HTTP is handled in a separate component. This component:

  1. Runs HTTP detection and extracts requests
  2. Handles raw IO on streams, exposing data through channels

This will allow for mirroring all redirected traffic, including HTTP requests. Basically, the component will be exposed to the new sniffer implementation, and wherever we have an mpsc channel, we'll also have a broadcast channel.

Behavior changes

  1. mirrord-agent runs HTTP detection on all redirected connections, even when we have an unfiltered subscription from the client. Current behavior - HTTP detection is run only when there is a filtered steal subscription.
  2. mirrord-agent runs a TLS server always when there is a TLS steal config for the destination port. So it now handles non-HTTP TLS traffic. Current behavior - TLS server is run only when there is a TLS steal config and there is a filtered steal subscription.

The internal proxy has been ready for these since this PR.

@Razz4780 Razz4780 force-pushed the eager-http-detection branch 3 times, most recently from 478ba8a to ceea36a Compare May 23, 2025 16:32
@Razz4780 Razz4780 force-pushed the eager-http-detection branch from 594328f to 67876ba Compare June 2, 2025 13:33
@Razz4780 Razz4780 requested review from t4lz and removed request for t4lz July 7, 2025 14:46
@Razz4780 Razz4780 added this pull request to the merge queue Jul 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 14, 2025
@Razz4780 Razz4780 added this pull request to the merge queue Jul 14, 2025
Merged via the queue into metalbear-co:main with commit 59d7999 Jul 14, 2025
18 checks passed
@Razz4780 Razz4780 deleted the eager-http-detection branch July 14, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants