Add CONTRIBUTING.md file #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the content here is adapted from various comments by various people on github issues and pull requests. It isn't intended to be a significant departure from how we have been working for the past month or so.
digama0
reviewed
Jan 23, 2022
|
Fine with me. Don't be bothered about the merge conflict with #41. I'll fix that. |
digama0
approved these changes
Jan 23, 2022
Co-authored-by: Mario Carneiro <[email protected]>
|
Given two approvals I'll go ahead and merge this. As usual, this doesn't have to be the end of review - if anyone sees anything they'd like to say differently, we can always open follow up pull requests. |
Oh wait I don't seem to have write access. I'm not sure whether I'll be doing enough metamath-exe work to quite need it, but feel free to either give me that access or merge this pull request yourself @digama0 |
This was referenced Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the content here is adapted from various comments by various
people on github issues and pull requests. It isn't intended to be a
significant departure from how we have been working for the past month
or so.
Fixes #8
Fixes #13
One administrative note: @digama0 and @wlammen do we want to merge #41 first? If so, I'd be glad to do the merge between those changes and this one. Or if we think that one isn't ready, then this one could go first.