Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put parse trees in database order #173

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

put parse trees in database order #173

wants to merge 3 commits into from

Conversation

digama0
Copy link
Member

@digama0 digama0 commented Oct 28, 2024

fixes #170

@digama0 digama0 mentioned this pull request Oct 28, 2024
Open
@tirix tirix mentioned this pull request Oct 28, 2024
Merged
@tirix
Copy link
Collaborator

tirix commented Oct 28, 2024

In some cases the grammar test checks the internal parse tree.
Could it be that those tests fail because that tree order has changed?

@digama0
Copy link
Member Author

digama0 commented Oct 28, 2024

yes, the test changes are desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse trees are in source order instead of argument order
2 participants
@digama0 @tirix