-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change sortComparePriority contract #319
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome, and thanks for the contribution.
From what I can tell right now, you haven't updated the documentation despite marking it as done in the pull request description.
Rebase on master and update the documentation, please.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've changed the function signature, but you still haven't updated the documentation apart from the usage example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation still isn't updated according to the changes to the function's signature.
@@ -21,19 +21,21 @@ const CONFIG_FILES_PRIORITY = [ | |||
'routes.js', | |||
]; | |||
|
|||
const compareFunction = common.sortComparePriority(CONFIG_FILES_PRIORITY); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I'd just inline the CONFIG_FILES_PRIORITY
at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will be landed before the next major version release.
Fixes #318
npm run fmt
)npm run doc
to regenerate documentation based on comments)Unreleased
header in CHANGELOG.md