Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript infrastructure and typings #344

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

lundibundi
Copy link
Member

  • code is properly formatted (npm run fmt)
  • tests are added/updated
  • documentation is updated (npm run doc to regenerate documentation based on comments)
  • description of changes is added under the Unreleased header in CHANGELOG.md

Since I always have the Iterator typings in my TS projects anyway I guess we could add them here, I'd support these to the best of my ability.
Not sure what would be the best way to go for other modules but since they rarely change I guess we could just type them as well. I would not change the process of PRing changes to include TS as people may not be familiar with it but rather someone updates them as we go forward (preferably before release 😄 ).

/cc @belochub

package.json Outdated Show resolved Hide resolved
@lundibundi
Copy link
Member Author

@tshemsedinov @nechaido @belochub @SemenchenkoVitaliy this is waiting for feedback (in general) to decide whether to go on with it. If we approve this idea/approach I could go on adding typings for other modules in common.
(I guess if you're fine with it you can just 👍 this comment, and otherwise comment)

@tshemsedinov
Copy link
Member

I believe we need ts typings ASAP, tkanks for this initiative 👍 @lundibundi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants