Skip to content

Update the feedstock #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 23, 2025
Merged

Update the feedstock #1

merged 15 commits into from
Apr 23, 2025

Conversation

Luthaf
Copy link
Member

@Luthaf Luthaf commented Apr 22, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@Luthaf Luthaf requested a review from abmazitov as a code owner April 22, 2025 09:29
@Luthaf Luthaf marked this pull request as draft April 22, 2025 09:30
@Luthaf Luthaf force-pushed the dev branch 13 times, most recently from 5be4eb9 to 26cf693 Compare April 22, 2025 15:44
@Luthaf Luthaf marked this pull request as ready for review April 23, 2025 09:15
- {{ compiler('cuda') }} # [cuda_compiler_version != "None"]
- rust
# - {{ compiler('cuda') }} # [cuda_compiler_version != "None"]
- {{ mpi }} # [build_platform != target_platform and mpi == "openmpi"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to exclude the mpich here and only leave an option for openmpi?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the recommended way to do this in https://conda-forge.org/docs/maintainer/knowledge_base/#message-passing-interface-mpi

Basically, mpich does not need to be listed in the host for cross-compilation, but openmpi does. We don't use cross-compilation yet, but we might soon to enable building for linux-arm64

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay good

@Luthaf Luthaf merged commit a4f4ea8 into metatensor:main Apr 23, 2025
9 checks passed
@Luthaf Luthaf deleted the dev branch April 23, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants