Skip to content

Fix the version and ability to use cuda devices #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

Luthaf
Copy link
Member

@Luthaf Luthaf commented Apr 25, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@Luthaf Luthaf requested a review from abmazitov as a code owner April 25, 2025 12:57
@@ -32,7 +34,7 @@

package:
name: lammps-metatensor
version: {{ conda_version }}
version: {{ conda_version }}.mts{{ git_rev_count }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the version looks like 2025.02.04.mts0, 2025.02.04.mts1, 2025.02.04.mts3 as we build different commits of https://github.com/metatensor/lammps that all correspond to lammps v2025.02.04

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this way conda will pick new builds first, since they will have a higher version

@Luthaf Luthaf mentioned this pull request Apr 28, 2025
5 tasks
@Luthaf Luthaf changed the title Make sure the version is different for each git commit we build Fix the version and ability to use cuda devices Apr 28, 2025
@Luthaf Luthaf requested a review from abmazitov April 28, 2025 09:41
@Luthaf Luthaf merged commit 1688862 into metatensor:main Apr 28, 2025
18 checks passed
@Luthaf Luthaf deleted the different-version-for-different-commit branch April 28, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants