Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorials #7

Closed
wants to merge 2 commits into from
Closed

Update tutorials #7

wants to merge 2 commits into from

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Nov 2, 2021

The tutorials did not work when a new guy tried to run them. In the tutorials only change that needed to be implemented was TestDataAccess -> AccessTestData, but there are some changes to some plotting functions in pyaerocom. These are found in a PR in pyaerocom

@dulte
Copy link
Collaborator Author

dulte commented Nov 2, 2021

The tutorials also have my results now

@dulte
Copy link
Collaborator Author

dulte commented Nov 2, 2021

@jgliss sorry to disturb you in your new job, but I can not assign reviewers, so I think you have to do it. Might be because it is a PR from my fork(?)

@avaldebe avaldebe changed the title Update tuts Update tutorials Nov 3, 2021
@avaldebe avaldebe self-requested a review November 3, 2021 13:32
Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to merge

@heikoklein
Copy link
Member

@dulte Cant this pr be closed or merged?

@heikoklein heikoklein added this to the m2024-06 milestone May 10, 2024
@thorbjoernl
Copy link
Collaborator

thorbjoernl commented May 14, 2024

This PR no longer resolves the issue as the AccessTestData().download() which the tutorial relies on no longer exists in Pyaerocom (it was moved to a fixture and is therefore part of the test code).

See metno/pyaerocom#1168

@dulte
Copy link
Collaborator Author

dulte commented May 31, 2024

Blocks this PR until metno/pyaerocom#1168 is fixed

@dulte dulte modified the milestones: m2024-06, m2024-07 Jun 4, 2024
@lewisblake
Copy link
Member

#1168 was fixed by #1188 so this issue can go ahead now

@dulte
Copy link
Collaborator Author

dulte commented Jun 18, 2024

Everything should now be fixed with #12

@dulte dulte closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants