Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty colocated object when start and stop are not given #1211

Open
dulte opened this issue Jun 18, 2024 · 2 comments · May be fixed by #1212
Open

Empty colocated object when start and stop are not given #1211

dulte opened this issue Jun 18, 2024 · 2 comments · May be fixed by #1212
Assignees
Labels
bug 🐛 Something isn't working
Milestone

Comments

@dulte
Copy link
Collaborator

dulte commented Jun 18, 2024

Describe the bug
The colocator returns an empty object when no start and stop are given in the colocation setup

To Reproduce
Steps to reproduce the behavior:

  1. Make a colocation setup without start and stop
  2. Run a colocator with said setup
  3. The result is an empty colocated object
@dulte dulte added the bug 🐛 Something isn't working label Jun 18, 2024
@dulte dulte added this to the m2024-07 milestone Jun 18, 2024
@dulte dulte self-assigned this Jun 18, 2024
@dulte
Copy link
Collaborator Author

dulte commented Jun 18, 2024

This is a bigger (design) issue than first thought. #1212 makes the tutorials work, but breaks tests.

The way it is done #1212 work to some degree, but keeps the old notion that if no start and stop are given, then pyaerocom try to infer them. More tests need to be made before this PR is ready

We have tried to make start and stop mandatory to define in colocation setup, but this breaks the tests. This is because a "default" ColocationSetup can't exist now; it must be given atleast start and stop.

We need to decide how we want ColocationSetup to work

  1. Start/stop is optional, and pyaerocom can infer them.
  2. Start/stop must be given by the user.

@heikoklein heikoklein modified the milestones: m2024-07, m2024-09 Jun 18, 2024
@heikoklein heikoklein modified the milestones: m2024-09, m2024-10 Sep 10, 2024
@dulte
Copy link
Collaborator Author

dulte commented Sep 30, 2024

We will go for option 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants