Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tutorials usable #12

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Make tutorials usable #12

merged 7 commits into from
Nov 13, 2024

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Jun 18, 2024

Fixes most of the tutorials.

  • intro_emep still doesn't work. There are some issues with it and the new test-data minimal (eg. the section on unconventionally named data does not work because current version of test-data-minimal does not include this file).

@heikoklein heikoklein changed the title Make usable Make tutorials usable Jun 18, 2024
@dulte dulte modified the milestones: m2024-07, m2024-08 Jun 21, 2024
@heikoklein heikoklein modified the milestones: m2024-08, m2024-09 Aug 14, 2024
@heikoklein heikoklein modified the milestones: m2024-09, m2024-10 Sep 10, 2024
@heikoklein heikoklein modified the milestones: m2024-10, m2024-11 Oct 14, 2024
@heikoklein heikoklein modified the milestones: m2024-11, m2024-12 Nov 8, 2024
@heikoklein
Copy link
Member

@thorbjoernl What is the status here?

@thorbjoernl
Copy link
Collaborator

I believe this was put on hold because it is blocked by metno/pyaerocom#1211 (comment)

@heikoklein
Copy link
Member

I believe this was put on hold because it is blocked by metno/pyaerocom#1211 (comment)

I don't understand that. Can't we just add a start and stop to the tutorial for collocator? Why do we need something in the tutorials which needs long-term development. Can you run through the tutorials and say what is not working?

@thorbjoernl
Copy link
Collaborator

It does indeed run with start and stop specified. Some other minor issues with downloading the testdata since that has been changed recently but should be fixable.

@thorbjoernl
Copy link
Collaborator

I don't have access to push to this repo. Could you give me access @heikoklein ?

@heikoklein
Copy link
Member

I don't have access to push to this repo. Could you give me access @heikoklein ?

Sorry, you should have access now.

@thorbjoernl
Copy link
Collaborator

I think I resolved the merge conflicts now, but probably best if somebody else gives this a review.

@heikoklein heikoklein self-requested a review November 13, 2024 11:16
Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output shows that these changes have been made with 0.21.0.dev0 rather than the current 0.24.0
Since the basics of this PR - making the tutorials usable again is fulfilled, I will merge. Soon coming future PRs on the tutorials are welcome.

@heikoklein heikoklein merged commit 4d7a464 into master Nov 13, 2024
@heikoklein
Copy link
Member

Errors not related to this PR (but related to making tutorials usable). Please decide if you want to create new PRs for those.

In add_stationdata.ipynb
! tail -n 14 AERONET_V2_SDA_od550gt1aer2010_EastAsia.csv
must be
! tail -n 14 demo_datasets/AERONET_V2_SDA_od550gt1aer2010_EastAsia.csv

In intro_emep.ipynb:
from pyaerocom.testdata_access import TestDataAccess does not exist.

Running run_all.py:

  File "/home/heikok/Programme/Python/pyaerocom-tutorials/run_all.py", line 17, in <module>
    user_server_avail = const.has_access_users_database
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/modules/rhel8/user-apps/fou-kl/aerotools/pya-v2024.11/lib/python3.11/site-packages/pyaerocom/config.py", line 330, in has_access_users_database
    chk_dir = self._check_subdirs_cfg["users-db"]
              ^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Config' object has no attribute '_check_subdirs_cfg'```

@heikoklein heikoklein deleted the make-usable branch November 13, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants