-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tutorials usable #12
Conversation
@thorbjoernl What is the status here? |
I believe this was put on hold because it is blocked by metno/pyaerocom#1211 (comment) |
I don't understand that. Can't we just add a start and stop to the tutorial for collocator? Why do we need something in the tutorials which needs long-term development. Can you run through the tutorials and say what is not working? |
It does indeed run with start and stop specified. Some other minor issues with downloading the testdata since that has been changed recently but should be fixable. |
I don't have access to push to this repo. Could you give me access @heikoklein ? |
Sorry, you should have access now. |
I think I resolved the merge conflicts now, but probably best if somebody else gives this a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output shows that these changes have been made with 0.21.0.dev0 rather than the current 0.24.0
Since the basics of this PR - making the tutorials usable again is fulfilled, I will merge. Soon coming future PRs on the tutorials are welcome.
Errors not related to this PR (but related to making tutorials usable). Please decide if you want to create new PRs for those. In In Running
|
Fixes most of the tutorials.