Skip to content

First pass on removing nan values in model from obs with colocate time #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main-dev
Choose a base branch
from
Draft

First pass on removing nan values in model from obs with colocate time #755

wants to merge 1 commit into from

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Oct 11, 2022 •
edited
Loading

Then colocate_time=True, model values are removed where you have nan obs. The reverse is not the case. This is to fix that. See #736

@dulte dulte requested a review from lewisblake October 11, 2022 08:46
@dulte dulte mentioned this pull request Oct 11, 2022
Closed
@lewisblake
Copy link
Member

@dulte would you like help with this?

@lewisblake lewisblake mentioned this pull request Oct 27, 2022
Closed
@lewisblake lewisblake mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lewisblake lewisblake Awaiting requested review from lewisblake

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dulte @lewisblake