One approach to fixing lazy parsing of registries via from-ast #1185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
-property-registry
was defeating all the laziness of-delayed-registry
infrom-ast
.I'm not sure which way to go with this. Some options:
-property-registry
and allow:properties
to be a map from key toIntoSchema
. This works for straightforward cases because-property-registry
is called again to coerce the properties back to forms, and-property-registry
always callsm/schema
first. But this changes the output of(-> s m/properties :registry)
.-property-registry
to wrap schemas in a similar way to-proxy-schema
, such as(-property-registry r options #(reify Schema (-validator [_] (m/schema % options)) ...)
-delayed-registry
. Performance is apparently still great without laziness compared to vector syntax.This PR implements option 1 to demonstrate the problem.
Also refactors
cond
intoif
, removing redundant tests.