Make 'message' last element of mail-format in monitrc.erb#34
Open
johnzimm wants to merge 1 commit intometrixware-echoes-tech:masterfrom
Open
Make 'message' last element of mail-format in monitrc.erb#34johnzimm wants to merge 1 commit intometrixware-echoes-tech:masterfrom
johnzimm wants to merge 1 commit intometrixware-echoes-tech:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33. The "message" element in "mailformat" needs to be the last entry. Otherwise the elements following "message" after sorting get included in the body of the message. I've saved the value for "message", removed it from the hash, let the sort happen on the remaining elements, then append the saved message to the mailformat block before closing.
I've tested on my systems both supplying a custom message to the module and supplying no message to the module.