Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removal references to smc #926

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: removal references to smc #926

merged 1 commit into from
Nov 13, 2024

Conversation

ludtkemorgan
Copy link
Collaborator

@ludtkemorgan ludtkemorgan commented Nov 4, 2024

This PR addresses bloom-housing#4456

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Removes references to the SMC housing portal in the /get-started page

How Can This Be Tested/Reviewed?

On the http://localhost:3000/help/get-started page references to San Mateo should not be seen in the last two accordion sections

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link
Collaborator

@mcgarrye mcgarrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcgarrye mcgarrye added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Nov 12, 2024
@ludtkemorgan ludtkemorgan merged commit 7c2d51c into main Nov 13, 2024
16 checks passed
@ludtkemorgan ludtkemorgan deleted the 4456/smc-removal branch November 13, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants