extrac-param: provide size of each record via attribute #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use structure() to define the nmrec_flags attribute alongside the main value for 'want' rather than having special handling for a separate 'want_attr' value.
extract_theta(), extract_omega(), and extract_sigma() return a value that combines the values defined by all of the parameter's records. bbr wants to be able to determine which record a given value comes from, so expose the size of each record as an attribute. Closes #32.
|
Thanks, will rebase on main to get doc changes since plan is to make dev release from tip of this branch. |
kyleam
force-pushed
the
extra-param-sizes
branch
from
62cb68e to
fcdb688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the size of each record as an attribute for use by bbr.