Skip to content

add code quality workflow #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2024
Merged

add code quality workflow #22

merged 1 commit into from
Sep 18, 2024

Conversation

armaan-abraham
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0bcb51c) to head (d896f82).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          150       150           
=========================================
  Hits           150       150           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aarmey
Copy link
Member

aarmey commented Sep 18, 2024

Thanks!

@aarmey aarmey merged commit be38944 into main Sep 18, 2024
4 checks passed
@aarmey aarmey deleted the code-quality branch September 18, 2024 16:41
@armaan-abraham
Copy link
Collaborator Author

Wait, I didn't add pyright which I think is a good idea now that you mention it in Jackson's PR. I'm going to attempt to revert this.

@armaan-abraham armaan-abraham restored the code-quality branch September 18, 2024 16:45
armaan-abraham added a commit that referenced this pull request Sep 18, 2024
@armaan-abraham
Copy link
Collaborator Author

Nevermind, I'm just going to create a new PR and we can paste a link to the diff across PRs as a guide.

@armaan-abraham armaan-abraham deleted the code-quality branch September 18, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants