Fix failing tests on PHP 8.4 (follow-up to mezzio-swoole#137) #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristofer Karlsson <[email protected]> Signed-off-by: mmalac <[email protected]>
Signed-off-by: Kristofer Karlsson <[email protected]> Signed-off-by: mmalac <[email protected]>
Signed-off-by: Kristofer Karlsson <[email protected]> Signed-off-by: mmalac <[email protected]>
Signed-off-by: mmalac <[email protected]>
Signed-off-by: mmalac <[email protected]>
Signed-off-by: mmalac <[email protected]>
mairo744
force-pushed
the
update/php-84-fix
branch
from
3ddc3fe to
35d2071
Compare
|
Hi @gsteel, sorry to bother you — I just wanted to check if you might know who could review this PR, or point me in the right direction. I'd really appreciate any help. Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the test failures that occurred in mezzio-swoole#137, which introduced updates for PHP 8.4 compatibility.
Summary of Changes
inotifyon PHP 8.4Checklist
Notes
Targeting
masteras this is a bugfix/QA cleanup directly related to ensuring stability on PHP 8.4.