Skip to content

Add SetExceptionBreakpoint Optional Args#1378

Closed
blakekrpec wants to merge 8 commits intomfussenegger:masterfrom
blakekrpec:add-optional-args
Closed

Add SetExceptionBreakpoint Optional Args#1378
blakekrpec wants to merge 8 commits intomfussenegger:masterfrom
blakekrpec:add-optional-args

Conversation

@blakekrpec
Copy link

In nvim-dap, set_exception_breakpoints() exposes one of two optional args in the DAP spec (ExceptionOptions), and it is always nil. This PR adds the other optional arg (ExceptionFilterOptions) and exposes both optional args in defaults.

This allows for non nil definitions of both optional args in the default table if needed/desired, otherwise they will default to nil.

Tested with debugpy, codelldb, and the Unity debugger.

@Erifirin
Copy link

Oh yeah! 'filterOptions' is required for Unity debugger. It would be great to merge this PR.

@mfussenegger
Copy link
Owner

mfussenegger commented Dec 21, 2024

Oh yeah! 'filterOptions' is required for Unity debugger. It would be great to merge this PR.

It will be some time before I get to this, because I'll want to make sure the API fits with what I have in mind for #1388 and also see how to deal with #494 . Before that I won't be making any other public API changes to these methods.

In the meantime you could bully ask the billion $ company to fix their adapter to comply with the specification. filterOptions are supposed to be optional

@Erifirin
Copy link

@mfussenegger Yes, I understand. You are absolutely right. For now, I will continue to modify session.lua locally. Maybe this issue will be solved in the future.

@blakekrpec
Copy link
Author

It will be some time before I get to this, because I'll want to make sure the API fits with what I have in mind for #1388 and also see how to deal with #494 . Before that I won't be making any other public API changes to these methods.

Sounds good. I am happy to come back and refactor this PR is need be after you make any major changes for #1388 and/or #494.

In the meantime you could bully ask the billion $ company to fix their adapter to comply with the specification. filterOptions are supposed to be optional

Agreed, they should adhere to the spec. I tried their support avenues, and never heard back. I assume I never will, but was worth a shot...

@blakekrpec
Copy link
Author

blakekrpec commented Jan 3, 2025

I will continue to modify session.lua locally. Maybe this issue will be solved in the future.

@Erifirin I have my fork public and plan to keep it up while these changes aren't in nvim-dap. Feel free to use it if it saves you time over manually updating session.lua. Cheers.

@Erifirin
Copy link

Erifirin commented Jan 7, 2025

In the meantime you could bully ask the billion $ company to fix their adapter to comply with the specification. filterOptions are supposed to be optional

I did so. At least they promised to fix the bug in the next version of visualstudiotoolsforunity.vstuc.

@blakekrpec blakekrpec closed this by deleting the head repository Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants