Add SetExceptionBreakpoint Optional Args #1378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh yeah! 'filterOptions' is required for Unity debugger. It would be great to merge this PR. |
It will be some time before I get to this, because I'll want to make sure the API fits with what I have in mind for #1388 and also see how to deal with #494 . Before that I won't be making any other public API changes to these methods. In the meantime you could |
|
@mfussenegger Yes, I understand. You are absolutely right. For now, I will continue to modify session.lua locally. Maybe this issue will be solved in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nvim-dap, set_exception_breakpoints() exposes one of two optional args in the DAP spec (ExceptionOptions), and it is always nil. This PR adds the other optional arg (ExceptionFilterOptions) and exposes both optional args in defaults.
This allows for non nil definitions of both optional args in the default table if needed/desired, otherwise they will default to nil.
Tested with debugpy, codelldb, and the Unity debugger.