Update mocap_tools.py : compatible with a wider definition and avoid breaking if skeleton not found. #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix will help the mocap tool to build the control rig for a wider range of skeletons, and avoid breaking if some bones aren't found.
RemiCuxac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix will help the mocap tool to build the control rig for a wider range of skeletons, and avoid breaking if some bones aren't found.
Description of Changes
I added more bones inside the description in case the skeleton has more bones in the spine or the neck
and add a if statement in case those added bones aren't found in the current skeleton.
Testing Done
Worked for me !
Related Issue(s)
Initially, the mocap tool doesn't care if there is a Spine3 bone, and breaks if Neck1 isn't found (for exemple).