Refactor #30

gregori0o · 2022-10-26T19:24:01Z

Zmiana katalogów z plikami. Stworzenie więcej katalogów w widgets. W visualisation tylko Plot i canvas.
Wyodrębnienie pliku konfiguracyjnego.
Dodanie pre-commit (wyjaśnienie użytych argumentów tutaj i tutaj). - sposób użycie
Użycie select_dtypes w KMeansach tak jak jest w GMM.
Połączenie klas Canvas dla obydwu typów klastrowania.
Wyodrębnienie klasy w której jest cały komponent dla wizualizacji kroków przez algorytmy klasteryzacji bez wykresu, który podajemy jako argument, żeby łatwo można było zmienić bibliotekę do wizualizacji.
Komponent z parametrami algorytmów dla sekcji Result.
Komponent z tabelą z klastrami.
Mały widget z wyborem sampli i kolumn do wizualizacji przez wykres punktowy.
Dodanie wykresu punktowego w sekcji preprocessingu.
Aktualizacja wersji bibliotek.

Ważna uwaga: Komponenty komunikują się poprzez sygnały co jest zgodne z sposobem komunikacji w QT.

…plementations.

# Conflicts: # requirements.txt # src/widgets/options_widgets/__init__.py # src/widgets/results_widgets/__init__.py

…n. Move plots to visualization.

mhawryluk

so far so good :)

src/engines/algorithms_config.py

t0ms0n00

For now very very good effort, the code looks much more readable! I left one bug to resolve and one idea to think about.

src/engines/algorithms_engine.py

src/widgets/steps_widgets/extra_trees_vis.py

src/widgets/components/clustering_steps.py

mhawryluk

Well done! Just a few final suggestions from me

src/engines/algorithms_config.py

src/engines/preprocessing_engine.py

t0ms0n00

Last suggestions from me. You can merge automatically after changes.

src/algorithms/utils.py

src/engines/preprocessing_engine.py

gregori0o added 7 commits October 23, 2022 18:12

feat: Create abstract classes and adjust to extra trees and kmeans im…

7caf527

…plementations.

feat: Creat config file for Algorithm References.

979da8b

Merge branch 'develop' into @gregori0o/abstract-class-for-new-algorithms

4ecb517

# Conflicts: # requirements.txt # src/widgets/options_widgets/__init__.py # src/widgets/results_widgets/__init__.py

feat: Implement usage of algorithms_config.py file.

ef3092f

fix: Adjust algorithms to new classes

98e7fa8

refactor: Move steps visualization to widgets.steps_widgets

4c16710

refactor: Separate canvas from steps widgets and move to visualizatio…

bede648

…n. Move plots to visualization.

gregori0o self-assigned this Oct 26, 2022

mhawryluk reviewed Oct 26, 2022

View reviewed changes

src/engines/algorithms_config.py Outdated Show resolved Hide resolved

src/engines/algorithms_config.py Outdated Show resolved Hide resolved

fix: Review suggestions.

5ddc9d8

t0ms0n00 reviewed Oct 31, 2022

View reviewed changes

src/engines/algorithms_engine.py Outdated Show resolved Hide resolved

src/widgets/steps_widgets/extra_trees_vis.py Show resolved Hide resolved

gregori0o added 16 commits November 7, 2022 22:04

fix: Review suggestion

6011f08

refactor: Add pre-commit

b60aab6

fix: Problems with imports

292a0c3

refactor: Small changes

f19cff3

refactor: Remove check_numeric and use delect_dtypes (as in GMM)

08d5b9b

refactor: Merge clustering canvas

a6cf914

refactor: Create component for step visualization

c43f9e0

refactor: Use ParametersGroupBox

f78fdbc

refactor: Add signals to clustering template

daa5be8

refactor: Separate ClustersTable class

a748883

fix: Not change section if linalg error in gmm

0af9259

refactor: Use widget to samples data and column choice

611b984

refactor: Remove fig and axes argument from canvas.

2e9fa50

feat: Add scatter plot in preprocessing section.

712264c

fix: Fix problems with pre-commit.

3405ecf

upgrade: Upgrade requirements

d0372a3

gregori0o marked this pull request as ready for review November 11, 2022 17:45

gregori0o requested review from mhawryluk and t0ms0n00 November 11, 2022 17:45

gregori0o added 2 commits November 13, 2022 21:40

refactor: All algorithms in config was done.

24f1f54

Merge branch 'develop' into @gregori0o/refactor

3ef6e7a

mhawryluk reviewed Nov 21, 2022

View reviewed changes

src/widgets/components/clustering_steps.py Outdated Show resolved Hide resolved

gregori0o added 2 commits November 21, 2022 21:40

Merge branch 'develop' into @gregori0o/refactor

38e1493

fix: Apply review suggestion.

caa8020

mhawryluk approved these changes Nov 22, 2022

View reviewed changes

src/engines/algorithms_config.py Outdated Show resolved Hide resolved

src/engines/preprocessing_engine.py Outdated Show resolved Hide resolved

fix: Apply review suggestion.

e311b4a

t0ms0n00 approved these changes Nov 27, 2022

View reviewed changes

src/algorithms/utils.py Outdated Show resolved Hide resolved

src/engines/preprocessing_engine.py Outdated Show resolved Hide resolved

gregori0o added 3 commits November 29, 2022 19:24

fix: Small changes from review.

443b7a5

style: Apply pre-commit

81d57b5

Merge branch 'develop' into @gregori0o/refactor

86b467d

gregori0o merged commit ec0cd7f into develop Nov 29, 2022

gregori0o deleted the @gregori0o/refactor branch December 3, 2022 12:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor #30

Refactor #30

gregori0o commented Oct 26, 2022 •

edited

Loading

mhawryluk left a comment

t0ms0n00 left a comment •

edited

Loading

mhawryluk left a comment

t0ms0n00 left a comment

Refactor #30

Refactor #30

Conversation

gregori0o commented Oct 26, 2022 • edited Loading

mhawryluk left a comment

Choose a reason for hiding this comment

t0ms0n00 left a comment • edited Loading

Choose a reason for hiding this comment

mhawryluk left a comment

Choose a reason for hiding this comment

t0ms0n00 left a comment

Choose a reason for hiding this comment

gregori0o commented Oct 26, 2022 •

edited

Loading

t0ms0n00 left a comment •

edited

Loading