Skip to content

Conversation

@veliu
Copy link
Collaborator

@veliu veliu commented Dec 31, 2025

This pull request introduces several updates to modernize the codebase, improve compatibility, and enhance test quality. The most significant changes include updating PHP and dependency requirements, migrating test annotations to attributes, and improving test assertions for stricter type checks. There are also some minor documentation and configuration updates.

Dependency and compatibility updates:

  • Updated composer.json to require PHP 8.4 or newer, updated Symfony Console and Webmozart Assert dependencies, and bumped dev dependencies such as PHPUnit and Psalm. Added a conflict for stevebauman/unfinalize. [1] [2]
  • Adjusted .laminas-ci.json to ignore PHP platform requirements for 8.4 and enabled backward compatibility checks.

Testing improvements:

  • Migrated PHPUnit data providers from docblock @dataProvider annotations to PHP 8 attributes (#[DataProvider(...)]) in tests/ValueTest.php for better IDE and static analysis support. [1] [2] [3] [4] [5] [6] [7]
  • Replaced assertEquals with assertSame in all tests for stricter type and value checking. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Configuration and documentation:

  • Updated phpunit.xml to use the <source> element instead of <coverage> for including source directories.
  • Updated CONTRIBUTE.md and README.md to fix typos, improve formatting, and correct the PHP CS Fixer command. [1] [2]
  • Allowed risky rules in .php-cs-fixer.dist.php by setting setRiskyAllowed(true).

@veliu veliu force-pushed the feature/php8.5 branch 2 times, most recently from 79321f2 to d4faee0 Compare December 31, 2025 09:15
@veliu veliu changed the base branch from 2.x to 1.x January 6, 2026 10:50
Copy link
Owner

@michaelpetri michaelpetri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm expect the bc break and the dependency to webmozart/assert which should be dropped, or did I missed something?

- Support Symfony8.0
- Dropped PHP8.2 and 8.3 Support
@veliu veliu requested a review from michaelpetri January 6, 2026 19:29
Copy link
Owner

@michaelpetri michaelpetri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, feel free to 🚢

@veliu veliu requested a review from michaelpetri January 7, 2026 19:10
@veliu veliu merged commit a406f36 into 1.x Jan 7, 2026
18 checks passed
@veliu veliu deleted the feature/php8.5 branch January 7, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants